Reconstruction logic for padding bytes at the end of Reports (only possible for devices without ReportID) #707

2024-10-27T13:34:57-05:00

JoergAtGithub commented

2024-10-27 13:34:57 -05:00

(Migrated from github.com)

Added reconstruction logic of const padding bytes at the end of a report for devices which don't use ReportIDs
Enhanced padding logic to distinguish between byte and bit padding.
Added a new test case for Razer Cobra mouse 1532_00A3_0002_0001 which has a completly con feature report of 90 bytes.
Modified expected report descriptor reference file 045E_02FF_0005_0001_expected.rpt_desc to include additional padding bytes.

Closes: #703

- Added reconstruction logic of const padding bytes at the end of a report for devices which don't use ReportIDs - Enhanced padding logic to distinguish between byte and bit padding. - Added a new test case for Razer Cobra mouse `1532_00A3_0002_0001` which has a completly con feature report of 90 bytes. - Modified expected report descriptor reference file `045E_02FF_0005_0001_expected.rpt_desc` to include additional padding bytes. Closes: #703

Youw (Migrated from github.com) reviewed

2024-10-28 07:28:23 -05:00

windows/hidapi_descriptor_reconstruct.c

					
				@ -537,7 +537,10 @@ int hid_winapi_descriptor_reconstruct_pp_data(void *preparsed_data, unsigned cha

							}

		// Windows pp_data are per top-level collection, therefore top level coll end is unique

```suggestion // Windows pp_data are per top-level collection, therefore top level coll end is unique ```

Youw commented

2024-10-29 04:00:14 -05:00

(Migrated from github.com)

If someone could test/verify this - I'll approve/merge.

👍 1

mcuee commented

2024-10-29 05:18:12 -05:00

(Migrated from github.com)

Not sure if I have test devices which can test the improvement in this PR. Still I will check with my existing devices to see if there are any differences.

SuibianP (Migrated from github.com) approved these changes

2024-10-30 05:51:38 -05:00

SuibianP (Migrated from github.com) left a comment