Android: Replace own pthread_barrier and iconv implementations by the one from Bionic #751
Labels
No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-libusb/hidapi#751
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In 2014 Android Bionic didn't had pthread_barrier and iconv implementations and therefore own implementations of them were added to the hidapi sources:
github.com/libusb/hidapi@417b2bf081 (diff-516ed9d234)But since API level 24, which was released in 2016, Androids Bionic C standard library contains the pthread_barrier functions: https://android.googlesource.com/platform/bionic/+/master/docs/status.md
Since API level 28 (released in 2018), also iconv was added to Bionic.
For historical reasons: here is Android iconv implementation: https://android-review.googlesource.com/c/platform/bionic/+/464455/3/libc/bionic/iconv.cpp