Android: Replace own pthread_barrier and iconv implementations by the one from Bionic #751

Open
opened 2025-06-15 02:18:24 -05:00 by JoergAtGithub · 1 comment
JoergAtGithub commented 2025-06-15 02:18:24 -05:00 (Migrated from github.com)

In 2014 Android Bionic didn't had pthread_barrier and iconv implementations and therefore own implementations of them were added to the hidapi sources: github.com/libusb/hidapi@417b2bf081 (diff-516ed9d234)

But since API level 24, which was released in 2016, Androids Bionic C standard library contains the pthread_barrier functions: https://android.googlesource.com/platform/bionic/+/master/docs/status.md

Since API level 28 (released in 2018), also iconv was added to Bionic.

In 2014 Android Bionic didn't had pthread_barrier and iconv implementations and therefore own implementations of them were added to the hidapi sources: https://github.com/libusb/hidapi/commit/417b2bf0812fa0926704b4cd9cd90af3194a172c#diff-516ed9d234e81614e6fa65cfc81a50b8b119e8a0769b2e66a1c89166bac437f7L44-R479 But since API level 24, which was released in 2016, Androids Bionic C standard library contains the pthread_barrier functions: https://android.googlesource.com/platform/bionic/+/master/docs/status.md Since API level 28 (released in 2018), also iconv was added to Bionic.
Youw commented 2025-06-15 02:48:56 -05:00 (Migrated from github.com)

For historical reasons: here is Android iconv implementation: https://android-review.googlesource.com/c/platform/bionic/+/464455/3/libc/bionic/iconv.cpp

For historical reasons: here is Android iconv implementation: https://android-review.googlesource.com/c/platform/bionic/+/464455/3/libc/bionic/iconv.cpp
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi#751
No description provided.