Added support for version 9 ark headers. #12

2017-09-11T19:41:27-05:00

PikminGuts92 commented

2017-09-11 19:41:27 -05:00

(Migrated from github.com)

In response to submitted issue #11
I also added in a check for ark version 8, which I know hasn't been observed yet. But we might get lucky.

In response to submitted issue #11 I also added in a check for ark version 8, which I know hasn't been observed yet. But we might get lucky.

maxton (Migrated from github.com) requested changes

2017-09-12 00:36:41 -05:00

maxton (Migrated from github.com) left a comment

Thanks for the PR. I don't have any version 9 arks to look at, but I trust you've tested this. Two nits and I'll merge 👍

Library/Ark/ArkPackage.cs

					
				@ -344,9 +346,9 @@ namespace GameArchives.Ark

				    }

Since this loop is almost the same as the one above, except for skipping the checksum, can you just move the readHash check to within the loop? I'd like to try to minimize duplicate code.

Since this loop is almost the same as the one above, except for skipping the checksum, can you just move the `readHash` check to within the loop? I'd like to try to minimize duplicate code.

It would be a bit less wasteful to just do header.Position += 4 or header.Seek(4, SeekOrigin.Current) with a comment explaining that there's a checksum we're ignoring.

It would be a bit less wasteful to just do `header.Position += 4` or `header.Seek(4, SeekOrigin.Current)` with a comment explaining that there's a checksum we're ignoring.

maxton commented

2017-09-12 00:39:08 -05:00

(Migrated from github.com)

Oh, and if you could also update the readme to mention the PS3 version of Amplitude and the new version number under the supported formats, that would be great.

PikminGuts92 (Migrated from github.com) reviewed

2017-09-12 03:44:23 -05:00

Library/Ark/ArkPackage.cs

					
				@ -344,9 +346,9 @@ namespace GameArchives.Ark

				    }

I did it this way so there'd only be one comparison instead of x comparisons (equal to file count). But I guess that's over optimization for our purpose.

PikminGuts92 (Migrated from github.com) reviewed

2017-09-12 03:49:20 -05:00

Library/Ark/ArkPackage.cs

					
				@ -344,9 +346,9 @@ namespace GameArchives.Ark

				    }

No excuse for this one. I'll fix it immediately.

maxton (Migrated from github.com) approved these changes

2017-09-12 08:18:56 -05:00

maxton commented

2017-09-12 08:19:40 -05:00

(Migrated from github.com)

Thanks!

Sign in to join this conversation.

No reviewers

maxton

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-maxton/GameArchives!12

Rows
Columns