Request: Volume Control for obs-browser #11
Labels
No labels
area/accessibility
area/dependency
Confirmed
Crash Report
Delayed
Design Issue
Duplicate
Feedback required
Good first issue
kind/bug
kind/cleanup
kind/enhancement
platform/linux
platform/macos
platform/windows
priority/high
Question
Request for Comments
Seeking Other Contributors
Seeking Testers
Won't Fix / By Design
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-obsproject/obs-browser#11
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently there is no way to mute sounds from pages.
Additional if one uses the browser to embed twitchalerts (with sound) on multiple scenes they all play on event trigger.
You can unload the browser source when it's not showing.
Thanks Gol-D-Ace,
well this solves my immediate problem, will leave the request open 'cause it still would be very nice to be able to change the volume of a browser source.
Unfortunately until CEF supports that kind of handling of audio, that won't happen.
Would this mean adding an "audio source" in the panel for this individual browser source instance (in the event I had multiple browser sources instances)?
That is exactly what i would like to see. Individual volume controls per browser source instance in the scene. Given that it's supported ofc.
Different volume per scene item (rather than per source) is basically implemented internally but hasn't been put in to the main UI. The question is how to implement something like that in to the user interface in a way in which wouldn't be confusing or convoluted to most casual users.
But first CEF needs to support it.
CEF itself? I think it does. I know people have accomplished it elsewhere. I could be totally crazy though.
I know that vMix found a way to do it, somehow.
I just imagined that "Source Name" would show up in Mixer when the scene was selected, just like media sources do now.
The CEF docs don't seem to reference anything related to audio.
Ah, maybe it was a specific audio-related patch someone did. I really need to make time to contribute to the plugin.
Perhaps you saw this? https://bitbucket.org/chromiumembedded/cef/pull-requests/18/adding-audio-support/
Maybe there should really be two modes of operation, basic and advanced? My first idea was to separate studio mode and basic mode stronger, but on second thought that is probably not a good idea as you still may want the "staging" area to reconfigure your scenes during streaming/recording but otherwise want to use just basic functionality of OBS.
Advanced audio routing/control could be part of an "advanced" mode, with more knobs and shebang if you know what you are doing.
Since CEF on the way to add necessary (I guess?) changes at https://bitbucket.org/chromiumembedded/cef/pull-requests/177/add-ability-to-capture-audio-output-to
Are you planning to review this and implement separate audio sources for the Browser?
Btw, my use case: do not include audio playing in the one of browsers into the stream record file but keep it on the live stream.
It is related to #15 too.
Thanks for bringing this particular issue number to my attention.
There is now a browser source branch here (audio_support) which adds this capability. It will require testing, however it won't get merged to master until both CEF PRs have been reviewed and are confirmed to be merged with CEF. This is in case they change, as we want something relatively stable before we include it in OBS.
This is literally essential for us and until now we had to re-route OBS's whole output audio to itself via hacky means to control the browser audio which is quite unstable. Thank you for getting this drafted up so quick with the CEF PR's on the horizon!
Latest update: "Add ability to capture audio output to buffer via cef handler" has been tested by Marshall of CEF and it's looking very promising (could be merged soon). "Mute audio in the browser" has been resubmitted to ensure it covers all of Marshall's concerns, but it's looking like that one will be merged too.
These changes should not be expected in OBS v23 (RC came out today), but we're keeping a very close eye on this for a future version of OBS.
@WizardCM @DDRBoxman
Following up with some links, CEF PR 173 has been superseded by CEF PR 195.
CEF PR 177 currently looks like it will be merged into CEF 3683, though that may change. CEF PR 177 is undergoing some last minute changes at the moment.
Edit: @WizardCM Looks like you and I more or less covered the same thing. I'd typed up my comment earlier but didn't submit till just now, so we ended up cross--posting.
Looks like both PRs are about to get merged which is promising
CEF Branch 3683 now has both relevant PRs merged in: https://bitbucket.org/chromiumembedded/cef/branch/3683
PR #157 has been submitted.
SOLUTION!! sooo alot simpler than what yall are making it. Go to windows volume mixer and turn down OBS volume, it turns down the output volume of the browser for both your viewers and yourself! :D hope this helped
Whoops, looks like we forgot to close this ticket once we merged and released this capability! If you haven't already, update to OBS Studio v24.0.x :)