gh-obsproject/obs-browser
Watch
1
0
Fork
You've already forked obs-browser
 0
Code Issues 37 Pull requests 13 Releases 15 Wiki Activity

Change CMake behavior if CEF is not found #285

Merged
tytan652 merged 1 commit from force_options into master 2021-04-09 08:54:21 -05:00
Conversation 1 Commits 1 Files changed 1 +2 -4
tytan652 commented 2021-04-08 09:51:25 -05:00 (Migrated from github.com)

Continuation of this obs-studio PR

Description

CMake will now emit a fatal error if CEF is not found rather than "disabling" obs-browser.
Same if X11 is missing

Motivation and Context

Continuation of this obs-studio PR

Many Linux packagers doesn't seem to build OBS with obs-vst and obs-browser, or maybe they don't know about them.
So I create this PR, to make the packager really decide to include or not those two.

How Has This Been Tested?

I replace the obs-studio's submodule with a symlink to my local repo without setting CEF_ROOT_DIR

Types of changes

  • CMake changes

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.
Continuation of this [obs-studio PR](https://github.com/obsproject/obs-studio/pull/4483) <!--- Please fill out the following template, which will help other contributors review your Pull Request. --> <!--- Make sure you’ve read the contribution guidelines here: https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst --> ### Description CMake will now emit a fatal error if CEF is not found rather than "disabling" obs-browser. Same if X11 is missing <!--- Describe your changes in detail. --> <!--- If this change includes UI elements, please include screenshots. --> ### Motivation and Context Continuation of this [obs-studio PR](https://github.com/obsproject/obs-studio/pull/4483) Many Linux packagers doesn't seem to build OBS with obs-vst and obs-browser, or maybe they don't know about them. So I create this PR, to make the packager really decide to include or not those two. <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open GitHub Issue, or implements feature request --> <!--- from the Ideas page, please link to the issue here. --> ### How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> I replace the obs-studio's submodule with a symlink to my local repo without setting CEF_ROOT_DIR <!--- Include details of your testing environment (hardware, OS version, etc.),--> <!--- and the tests you ran, including how it may affect other areas of code. --> ### Types of changes - CMake changes <!--- What types of changes does your PR introduce? Uncomment all that apply --> <!--- - Bug fix (non-breaking change which fixes an issue) --> <!--- - New feature (non-breaking change which adds functionality) --> <!--- - Performance enhancement (non-breaking change which improves efficiency) --> <!--- - Code cleanup (non-breaking change which makes code smaller or more readable) --> <!--- - Breaking change (fix or feature that would cause existing functionality to change) --> <!--- - Documentation (a change to documentation pages) --> ### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate. - [ ] I have included updates to all appropriate documentation.
GeorgesStavracas (Migrated from github.com) approved these changes 2021-04-08 09:58:22 -05:00
GeorgesStavracas (Migrated from github.com) left a comment

I'm in favor of this change :)

I'm in favor of this change :)
Sign in to join this conversation.
Reviewers
No reviewers
GeorgesStavracas
Labels
Clear labels   
area/accessibility
Improves accessibility of the program

  
area/dependency
Issue is in external library or dependency, not OBS itself

  
Confirmed

   
Crash Report

   
Delayed
Merging has been delayed due to an issue

  
Design Issue
There is an issue with incorporating this pull request's design. It may take some time to finalize.

  
Duplicate

   
Feedback required
Issue does not contain enough information or is missing the template

  
Good first issue
New to contributing to OBS? Start here!

  
kind/bug
Categorizes issue or PR as related to a bug.

  
kind/cleanup
Non-breaking change which makes code smaller or more readable

  
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.

  
platform/linux

   
platform/macos

   
platform/windows

   
priority/high
This is an important PR

  
Question

   
Request for Comments
More feedback & discussion is requested

  
Seeking Other Contributors
This PR needs help from any other developers who are willing to give a crack at this code

  
Seeking Testers

   
Won't Fix / By Design
No labels
area/accessibility
area/dependency
Confirmed
Crash Report
Delayed
Design Issue
Duplicate
Feedback required
Good first issue
kind/bug
kind/cleanup
kind/enhancement
platform/linux
platform/macos
platform/windows
priority/high
Question
Request for Comments
Seeking Other Contributors
Seeking Testers
Won't Fix / By Design
Milestone
Clear milestone
No items
No milestone
OBS Studio 27.0
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!285
No description provided.