gh-obsproject/obs-browser
Watch
1
0
Fork
You've already forked obs-browser
 0
Code Issues 37 Pull requests 13 Releases 15 Wiki Activity

Fix stack smash crashes on Linux #493

Merged
hoshinolina merged 1 commit from fix-stack-smash-crashes into master 2025-08-20 16:02:38 -05:00
Conversation 5 Commits 1 Files changed 1 +3
hoshinolina commented 2025-07-26 06:49:42 -05:00 (Migrated from github.com)

Description

See: https://github.com/chromiumembedded/cef/issues/3912
Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2379591

How Has This Been Tested?

Local test build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.
### Description See: https://github.com/chromiumembedded/cef/issues/3912 Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2379591 ### How Has This Been Tested? Local test build ### Types of changes <!--- What types of changes does your PR introduce? Uncomment all that apply --> - Bug fix (non-breaking change which fixes an issue) ### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate. - [ ] I have included updates to all appropriate documentation.
kkartaltepe (Migrated from github.com) approved these changes 2025-07-26 10:27:22 -05:00
RytoEX commented 2025-07-28 16:20:37 -05:00 (Migrated from github.com)

cc @tytan652 @GeorgesStavracas

Is this fixing an issue currently in the wild? Want to gauge whether this needs to land in a 31.1.x release or if it can wait until a future major/minor release.

cc @tytan652 @GeorgesStavracas Is this fixing an issue currently in the wild? Want to gauge whether this needs to land in a 31.1.x release or if it can wait until a future major/minor release.
tytan652 commented 2025-07-29 00:05:27 -05:00 (Migrated from github.com)

It's not exclusive to 31.1 (earlier version have the issue) and will require to backport changes to CEF 127 to have NO_STACK_PROTECTOR defined and enable the decoration.

So in my opinion it can wait until a future major/minor release.

It's not exclusive to 31.1 (earlier version have the issue) and will require to backport changes to CEF 127 to have `NO_STACK_PROTECTOR` defined and enable the decoration. So in my opinion it can wait until a future major/minor release.
hoshinolina commented 2025-07-29 00:33:51 -05:00 (Migrated from github.com)

The main issue is noise for distros that have coredumps/reporting (like Fedora). Other than that it seems to be harmless since the crashes only happen on process exit.

For the fedora RPMs I will push this patch in so it's fixed there, since otherwise users will get abrt popups and file bugs with us (I already got one). I can't say about the effect for other distros or through the official Flatpak. If this has been going on for a while and nobody has complained about it yet, maybe it's fine to wait?

The main issue is noise for distros that have coredumps/reporting (like Fedora). Other than that it seems to be harmless since the crashes only happen on process exit. For the fedora RPMs I will push this patch in so it's fixed there, since otherwise users will get abrt popups and file bugs with us (I already got one). I can't say about the effect for other distros or through the official Flatpak. If this has been going on for a while and nobody has complained about it yet, maybe it's fine to wait?
RytoEX (Migrated from github.com) approved these changes 2025-08-15 16:35:06 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
kkartaltepe
RytoEX
Labels
Clear labels   
area/accessibility
Improves accessibility of the program

  
area/dependency
Issue is in external library or dependency, not OBS itself

  
Confirmed

   
Crash Report

   
Delayed
Merging has been delayed due to an issue

  
Design Issue
There is an issue with incorporating this pull request's design. It may take some time to finalize.

  
Duplicate

   
Feedback required
Issue does not contain enough information or is missing the template

  
Good first issue
New to contributing to OBS? Start here!

  
kind/bug
Categorizes issue or PR as related to a bug.

  
kind/cleanup
Non-breaking change which makes code smaller or more readable

  
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.

  
platform/linux

   
platform/macos

   
platform/windows

   
priority/high
This is an important PR

  
Question

   
Request for Comments
More feedback & discussion is requested

  
Seeking Other Contributors
This PR needs help from any other developers who are willing to give a crack at this code

  
Seeking Testers

   
Won't Fix / By Design
No labels
area/accessibility
area/dependency
Confirmed
Crash Report
Delayed
Design Issue
Duplicate
Feedback required
Good first issue
kind/bug
kind/cleanup
kind/enhancement
platform/linux
platform/macos
platform/windows
priority/high
Question
Request for Comments
Seeking Other Contributors
Seeking Testers
Won't Fix / By Design
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-obsproject/obs-browser!493
No description provided.