Multiple missing 'extern "C"' #104

Closed
opened 2021-02-09 04:53:26 -06:00 by geurtv · 2 comments
geurtv commented 2021-02-09 04:53:26 -06:00 (Migrated from github.com)

The following header files are all missing __cplusplus ifdef'ed 'extern "C"'

src/rp2_common/hardware_claim/include/hardware/claim.h
src/rp2_common/hardware_divider/include/hardware/divider.h
src/rp2_common/hardware_flash/include/hardware/flash.h
src/rp2_common/hardware_rtc/include/hardware/rtc.h
src/rp2_common/hardware_watchdog/include/hardware/watchdog.h
src/rp2_common/pico_bootrom/include/pico/bootrom.h
src/rp2_common/pico_stdio_semihosting/include/pico/stdio_semihosting.h
src/rp2_common/pico_stdio_uart/include/pico/stdio_uart.h
src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h

Also the following header-only files ... might want to add it for consistency:

src/rp2_common/hardware_base/include/hardware/address_mapped.h
src/rp2_common/hardware_resets/include/hardware/resets.h

The following header files are all missing __cplusplus ifdef'ed 'extern "C"' src/rp2_common/hardware_claim/include/hardware/claim.h src/rp2_common/hardware_divider/include/hardware/divider.h src/rp2_common/hardware_flash/include/hardware/flash.h src/rp2_common/hardware_rtc/include/hardware/rtc.h src/rp2_common/hardware_watchdog/include/hardware/watchdog.h src/rp2_common/pico_bootrom/include/pico/bootrom.h src/rp2_common/pico_stdio_semihosting/include/pico/stdio_semihosting.h src/rp2_common/pico_stdio_uart/include/pico/stdio_uart.h src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h Also the following header-only files ... might want to add it for consistency: src/rp2_common/hardware_base/include/hardware/address_mapped.h src/rp2_common/hardware_resets/include/hardware/resets.h
Wren6991 commented 2021-02-09 08:51:17 -06:00 (Migrated from github.com)

Thank you for giving the exhaustive list! Made things quicker.

Thank you for giving the exhaustive list! Made things quicker.
Wren6991 commented 2021-02-11 12:01:22 -06:00 (Migrated from github.com)

Fixed by #106

Fixed by #106
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk#104
No description provided.