Picotool does not build with current develop branch of pico-sdk #1225

Closed
opened 2023-02-06 06:35:23 -06:00 by ndabas · 2 comments
ndabas commented 2023-02-06 06:35:23 -06:00 (Migrated from github.com)

Picotool does not build with the current develop branch of pico-sdk, soon to be the v1.5.0 release. The add_library call in src/common/pico_usb_reset_interface/CMakeLists.txt has been changed to pico_add_library, which is defined in src/CMakeLists.txt. Not sure if it's a good idea to import that file into the picotool build.

Build output:

-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/bin/cc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/bin/c++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Using PICO_SDK_PATH from environment ('C:/Users/Nikhil/Documents/GitHub/pico-setup-windows/build/pico-sdk')
-- Found LIBUSB: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/lib/libusb-1.0.dll.a
CMake Error at C:/Users/Nikhil/Documents/GitHub/pico-setup-windows/build/pico-sdk/src/common/pico_usb_reset_interface/CMakeLists.txt:1 (pico_add_library):
  Unknown CMake command "pico_add_library".
System.Management.Automation.RemoteException
System.Management.Automation.RemoteException
-- Configuring incomplete, errors occurred!
Picotool does not build with the current develop branch of pico-sdk, soon to be the v1.5.0 release. The `add_library` call in [src/common/pico_usb_reset_interface/CMakeLists.txt](https://github.com/raspberrypi/pico-sdk/blob/develop/src/common/pico_usb_reset_interface/CMakeLists.txt) has been changed to `pico_add_library`, which is defined in `src/CMakeLists.txt`. Not sure if it's a good idea to import that file into the picotool build. Build output: ``` -- The C compiler identification is GNU 12.2.0 -- The CXX compiler identification is GNU 12.2.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/bin/cc.exe - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/bin/c++.exe - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done Using PICO_SDK_PATH from environment ('C:/Users/Nikhil/Documents/GitHub/pico-setup-windows/build/pico-sdk') -- Found LIBUSB: C:/Users/Nikhil/Downloads/Tools/msys64/mingw64/lib/libusb-1.0.dll.a CMake Error at C:/Users/Nikhil/Documents/GitHub/pico-setup-windows/build/pico-sdk/src/common/pico_usb_reset_interface/CMakeLists.txt:1 (pico_add_library): Unknown CMake command "pico_add_library". System.Management.Automation.RemoteException System.Management.Automation.RemoteException -- Configuring incomplete, errors occurred! ```
kilograham commented 2023-02-06 07:39:10 -06:00 (Migrated from github.com)

ah thanks

ah thanks
kilograham commented 2023-02-06 18:07:45 -06:00 (Migrated from github.com)

fixed by #1230
merged into develop

fixed by #1230 merged into develop
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk#1225
No description provided.