pico_cyw43_driver/cyw43_bus_pio_spi.c: make SPI_PROGRAM_NAME and CLOC… #1499

Merged
mvds00 merged 1 commit from pullreq1 into develop 2024-06-21 14:35:51 -05:00
mvds00 commented 2023-09-08 16:59:29 -05:00 (Migrated from github.com)

Fixes #1498

This patch allows to override the default value for SPI_PROGRAM_NAME and CLOCK_DIV in src/rp2_common/pico_cyw43_driver/cyw43_bus_pio_spi.c by defining CYW43_SPI_PROGRAM_NAME and/or CYW43_PIO_CLOCK_DIV.

This is useful when other cpu speeds are involved, e.g. running the Pi Pico W at 12 MHz from xosc.

Fixes #1498 This patch allows to override the default value for SPI_PROGRAM_NAME and CLOCK_DIV in src/rp2_common/pico_cyw43_driver/cyw43_bus_pio_spi.c by defining CYW43_SPI_PROGRAM_NAME and/or CYW43_PIO_CLOCK_DIV. This is useful when other cpu speeds are involved, e.g. running the Pi Pico W at 12 MHz from xosc.
matsobdev commented 2023-10-20 14:35:56 -05:00 (Migrated from github.com)

It would be nice to have full range of cpu speeds at runtime for Pico W.

It would be nice to have full range of cpu speeds at runtime for Pico W.
mvds00 commented 2023-10-21 03:50:28 -05:00 (Migrated from github.com)

I fully agree @matsobdev, the potential for power efficient applications is huge. But it involves a lot of changes. Running from xosc at 12 MHz with pll_sys disabled for example, is currently not possible using build settings alone. I think the first step in having the full range of cpu speeds available, would be to make the cpu speed and everything depending on it configurable at build time.

I fully agree @matsobdev, the potential for power efficient applications is huge. But it involves a lot of changes. Running from xosc at 12 MHz with pll_sys disabled for example, is currently not possible using build settings alone. I think the first step in having the full range of cpu speeds available, would be to make the cpu speed and everything depending on it configurable at build time.
ai6aj commented 2023-10-22 13:15:22 -05:00 (Migrated from github.com)

See also #1521 which allows the default clock divisor to be overridden at runtime, which is useful for Micropython etc. Both patches look like they can merge with each other without issue.

See also #1521 which allows the default clock divisor to be overridden at runtime, which is useful for Micropython etc. Both patches look like they can merge with each other without issue.
kilograham (Migrated from github.com) reviewed 2024-05-19 17:05:31 -05:00
kilograham (Migrated from github.com) left a comment

Would be nice to add a PICO_CONFIG comment so it is added to the docs

Would be nice to add a PICO_CONFIG comment so it is added to the docs
kilograham (Migrated from github.com) approved these changes 2024-06-21 14:35:46 -05:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!1499
No description provided.