USB PHY direct override registers are inconsistently named #1517

Open
opened 2023-09-20 14:31:15 -05:00 by MichaelBell · 0 comments
MichaelBell commented 2023-09-20 14:31:15 -05:00 (Migrated from github.com)

In hardware\regs\usb.h the DM pull up enable is named
USB_USBPHY_DIRECT_OVERRIDE_DM_PULLUP_OVERRIDE_EN_BITS
but DM pull down and DP pull up and down are named
USB_USBPHY_DIRECT_OVERRIDE_DP_PULLUP_EN_OVERRIDE_EN_BITS
I think the DM pull up name is more consistent with everything else.

In `hardware\regs\usb.h` the DM pull up enable is named `USB_USBPHY_DIRECT_OVERRIDE_DM_PULLUP_OVERRIDE_EN_BITS` but DM pull down and DP pull up and down are named `USB_USBPHY_DIRECT_OVERRIDE_DP_PULLUP_EN_OVERRIDE_EN_BITS` I think the DM pull up name is more consistent with everything else.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk#1517
No description provided.