gh-raspberrypi/pico-sdk

Watch

pico_flash should depend on hardware_exception #1698

New issue

Closed

opened 2024-05-06 20:27:00 -05:00 by jaguilar · 3 comments

jaguilar commented

2024-05-06 20:27:00 -05:00

(Migrated from github.com)

Hi there, I think pico_flash should depend on hardware_exception? It unconditionally includes hardware_exception, and if I try to compile a file that depends on pico_flash without editing the SDK, I get this compile error:

[build] /home/jaguilar/projects/pico-sdk/src/rp2_common/pico_flash/flash.c:8:10: fatal error: hardware/exception.h: No such file or directory
[build]     8 | #include "hardware/exception.h"
[build]       |          ^~~~~~~~~~~~~~~~~~~~~~

If I add hardware_exception to the dependency list of pico_flash then everything works as expected.

Hi there, I think pico_flash should depend on hardware_exception? It unconditionally includes hardware_exception, and if I try to compile a file that depends on pico_flash without editing the SDK, I get this compile error: ``` [build] /home/jaguilar/projects/pico-sdk/src/rp2_common/pico_flash/flash.c:8:10: fatal error: hardware/exception.h: No such file or directory [build] 8 | #include "hardware/exception.h" [build] | ^~~~~~~~~~~~~~~~~~~~~~ ``` If I add hardware_exception to the dependency list of pico_flash then everything works as expected.

kilograham commented

2024-05-18 18:36:01 -05:00

(Migrated from github.com)

it doesn't seem like the file actually needs the header on a quick check

it doesn't seem like the file actually needs the header on a quick check

jaguilar commented

2024-05-19 09:26:31 -05:00

(Migrated from github.com)

@kilograham Adjusted the pull request to remove the unneeded includes. Added a compilation test to show the before and after state. I don't know if you prefer to have tests like that in the tree. Let me know if not and I can remove it.

@kilograham Adjusted the pull request to remove the unneeded includes. Added a compilation test to show the before and after state. I don't know if you prefer to have tests like that in the tree. Let me know if not and I can remove it.

kilograham commented

2024-06-04 20:00:09 -05:00

(Migrated from github.com)

merged into develop

merged into develop

Sign in to join this conversation.

No labels

can't reproduce

code cleanliness

compiler version issues

hardware_clocks

hardware_exception

hardware_watchdog

needs reporter detail

newlib-multicore

pico_async_context

pico_binary_info

wifi integration

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk#1698

No description provided.