gh-raspberrypi/pico-sdk

Watch

SDK 2.0.0 release breaks comment in src/rp2_common/cmsis/CMakeLists.txt (with suggested correction) #2273

New issue

Closed

opened 2025-02-16 09:55:26 -06:00 by d-c-d · 1 comment

d-c-d commented

2025-02-16 09:55:26 -06:00

(Migrated from github.com)

s/these 3 lines/this line/

the edit of src/rp2_common/cmsis/CMakeLists.txt deleted 2 lines, but the comment was not updated
e.g. see git show 2.0.0 src/rp2_common/cmsis/CMakeLists.txt

 # ... using these 3 lines instead
 set(PICO_CMSIS_CORE_PATH ${CMAKE_CURRENT_LIST_DIR}/stub)
-set(PICO_CMSIS_VENDOR RaspberryPi)
-set(PICO_CMSIS_DEVICE RP2040)

The reader must pause when reading the comment before assuming that the 2.0.0 edit was not compilete
so I would suggest changing "these 3 lines" to "this line"

here is a patch
perl -i -pe 's/these 3 lines/this line/' src/rp2_common/cmsis/CMakeLists.txt

s/these 3 lines/this line/ the edit of `src/rp2_common/cmsis/CMakeLists.txt` deleted 2 lines, but the comment was not updated e.g. see `git show 2.0.0 src/rp2_common/cmsis/CMakeLists.txt` ``` # ... using these 3 lines instead set(PICO_CMSIS_CORE_PATH ${CMAKE_CURRENT_LIST_DIR}/stub) -set(PICO_CMSIS_VENDOR RaspberryPi) -set(PICO_CMSIS_DEVICE RP2040) ``` The reader must pause when reading the comment before assuming that the 2.0.0 edit was not compilete so I would suggest changing "these 3 lines" to "this line" here is a patch `perl -i -pe 's/these 3 lines/this line/' src/rp2_common/cmsis/CMakeLists.txt`

kilograham commented

2025-02-16 12:13:40 -06:00

(Migrated from github.com)

merged into develop

merged into develop

Sign in to join this conversation.

No labels

can't reproduce

code cleanliness

compiler version issues

hardware_clocks

hardware_exception

hardware_watchdog

needs reporter detail

newlib-multicore

pico_async_context

pico_binary_info

wifi integration

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk#2273

No description provided.