Add more defines related to partition tables #2581

New issue

Open

opened 2025-07-22 10:43:37 -05:00 by will-v-pi · 7 comments

will-v-pi commented

2025-07-22 10:43:37 -05:00

(Migrated from github.com)

It would be good to add some of the defines from https://github.com/raspberrypi/pico-examples/pull/627#pullrequestreview-3042818651 into the SDK, including adding defines for the family names (which can also be used by picotool).

kilograham commented

2025-07-22 17:04:50 -05:00

(Migrated from github.com)

punting this to 2.3.0 as we should probably add a library related to all this

will-v-pi commented

2025-07-23 06:04:55 -05:00

(Migrated from github.com)

Should raspberrypi/pico-examples#627 also be bumped until that library is added, or is it fine to merge it without the library and fix it up to use the library later?

kilograham commented

2025-07-23 08:48:36 -05:00

(Migrated from github.com)

yeah, i think it is fine - it shows you how to do it for now

andygpz11 commented

2025-07-30 04:14:41 -05:00

(Migrated from github.com)

Hi @will-v-pi As a part of this work, would it be possible to add a size definition for the workarea required when using the bootrom's flash API please?

We can then replace some hardcoded instances.

Thanks.

Hi @will-v-pi As a part of this work, would it be possible to add a size definition for the `workarea` required when using the bootrom's flash API please? We can then replace some hardcoded instances. Thanks.

andygpz11 commented

2025-07-30 11:01:25 -05:00

(Migrated from github.com)

Whilst I'm here, is there any appetite for adding something like:
#define UF2_BLOCK_SIZE 512 ?

I realise there's a static_assert(...) in uf2.h to guard against this struct being sized other than 512 but it would be nice if source could use a common definition - this must be immutable by now.
Apologies if I've missed something I could use.
Thanks.

Whilst I'm here, is there any appetite for adding something like: `#define UF2_BLOCK_SIZE 512` ? I realise there's a `static_assert(...)` in `uf2.h` to guard against this struct being sized _other_ than 512 but it would be nice if source could use a common definition - this must be immutable by now. Apologies if I've missed something I could use. Thanks.

lurch commented

2025-07-31 01:56:38 -05:00

(Migrated from github.com)

Apologies if I've missed something I could use.

This probably isn't what you'e looking for! 🤣

$ git grep -E "#define \w+ 512$"
test/kitchen_sink/btstack_config.h:#define MAX_ATT_DB_SIZE 512

i.e. No, there doesn't seem to be anything you've missed.

> Apologies if I've missed something I could use. This probably isn't what you'e looking for! 🤣 ```console $ git grep -E "#define \w+ 512$" test/kitchen_sink/btstack_config.h:#define MAX_ATT_DB_SIZE 512 ``` i.e. No, there doesn't seem to be anything you've missed.

👍 1

andygpz11 commented

2025-07-31 03:45:29 -05:00

(Migrated from github.com)