when running under FreeRTOS SMP, the timer task can attempt to free the CYW43 async context's statically allocated timer #2687
Labels
No labels
bazel
bluetooth
board settings
boot_stage2
bug
build
c++
can't reproduce
clang
clib-interface
cmsis
code cleanliness
code size
compiler version issues
cyw43_driver
debug
discussion
documentation
duplicate
dynamic_clock
elf2uf2
enhancement
errata
filesystem
flash layout
floating point
FreeRTOS
hardware_adc
hardware_claim
hardware_clocks
hardware_dma
hardware_exception
hardware_flash
hardware_gpio
hardware_i2c
hardware_irq
hardware_pio
hardware_pwm
hardware_rcp
hardware_rtc
hardware_spi
hardware_sync
hardware_uart
hardware_vreg
hardware_watchdog
hardware_xosc
help wanted
host
IAR
installation
invalid
linker scripts
lto
lwip
mbedtls
missing API
needs reporter detail
networking
newlib
newlib-multicore
non-c
non-cmake
non-gcc
openocd
orphan PR
OS integration
pico_async_context
pico_base
pico_binary_info
pico_flash
picolibc
pico_lwip
pico_malloc
pico_multicore
pico_printf
pico_runtime
pico_stdio
pico_stdio_usb
pico_sync
pico_time
pico_util
pioasm
port
question
review
review2
rtos interop
runtime init
static library
svd
test
tinyusb
vscode
wifi integration
wontfix
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-raspberrypi/pico-sdk#2687
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
hey there. while running FreeRTOS SMP 11.2.0 on SDK version 2.2.0 with static allocation enabled, I ran into an issue where calling
cyw43_arch_deinitfrom a FreeRTOS task would cause FreeRTOS to throw an assertion failure and hard fault:I think the series of events which precipitates this assertion failing are:
async_context_freertos_deinitcallsxTimerDeleteon the async context's associated timer, which enqueues an asynchronous timer delete command for the timer task.async_context_freertos_deinitcontinues executing past thememsetat the end of the function.async_context_freertos_deinitto delete the timer.prvProcessReceivedCommandscheckspxTimer->ucStatus, which has been cleared to 0, and decides the timer was dynamically allocated.vPortFreenotices that the statically-allocated timer isn't in a heap block and panics.I've verified that commenting out the memset at the bottom of
async_context_freertos_deinit(which seems to be redundant with a memset at the top ofasync_context_freertos_init) prevents the crash from happening.I've uploaded a gist of the app I'm running (with all the commented-out code removed but otherwise not cleaned up), as well as my FreeRTOSConfig.h and CMakeLists.txt: https://gist.github.com/vogon/4c08fdd31a565609d02cb2534a4386bd
Thanks for the good analysis. I will remove the redundant memset. I also wait for the timer to no longer be active - I don't like leaving the function until we've done our best to make sure deinit has completed
fix merged into develop