BINARY_INFO_MAKE_TAG uses non-portable uint typedef #3028

Closed
opened 2026-06-24 14:25:35 -05:00 by loopj · 1 comment
loopj commented 2026-06-24 14:25:35 -05:00 (Migrated from github.com)

The BINARY_INFO_MAKE_TAG macro in the binary_info module relies on uint being defined, which is only true when building as part of the pico SDK (or if we happened to already have this typedef'd ourselves).

In pico/binary_info/structure.h it explicitly states:

NOTE: This file may be included by non SDK code, so does not use SDK includes

I ran into this issue when using these headers in my own library, it seems like the most portable solution here is to just use unsigned int directly.

I'll follow up with a PR.

The [`BINARY_INFO_MAKE_TAG`](https://github.com/raspberrypi/pico-sdk/blob/develop/src/common/pico_binary_info/include/pico/binary_info/structure.h#L45) macro in the `binary_info` module relies on `uint` being defined, which is only true when building as part of the pico SDK (or if we happened to already have this typedef'd ourselves). In [`pico/binary_info/structure.h`](https://github.com/raspberrypi/pico-sdk/blob/develop/src/common/pico_binary_info/include/pico/binary_info/structure.h#L10) it explicitly states: > NOTE: This file may be included by non SDK code, so does not use SDK includes I ran into this issue when using these headers in my own library, it seems like the most portable solution here is to just use `unsigned int` directly. I'll follow up with a PR.
kilograham commented 2026-06-30 09:19:48 -05:00 (Migrated from github.com)

merged into develop

merged into develop
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk#3028
No description provided.