Would you be averse to naming this clintech_cpb.h ? (which is the convention that other 3rd-party boards tend to use, and also might make it easier for people to figure out what "CPB" is referring to 🙂 )
The https://clintech.net/CPB/CPB3.jpg photo shows that you're using RP2354B0A4 which I think means you could safely set PICO_RP2350_A2_SUPPORTED to 0 ?
Otherwise this LGTM.

Would you be averse to naming this `clintech_cpb.h` ? (which is the convention that other 3rd-party boards tend to use, and also might make it easier for people to figure out what "CPB" is referring to :slightly_smiling_face: ) The https://clintech.net/CPB/CPB3.jpg photo shows that you're using RP2354B0A4 which I think means you could safely set `PICO_RP2350_A2_SUPPORTED` to 0 ? Otherwise this LGTM.

rallepalaveev commented

2026-07-23 06:12:31 -05:00

(Migrated from github.com)

Hi,

Thank you for the recommendations.

I have renamed the file to clintech_cpb.h
I have changed line 84: #define PICO_RP2350_A2_SUPPORTED 0

Kind regards,

Ralle

Hi, Thank you for the recommendations. I have renamed the file to clintech_cpb.h I have changed line 84: #define PICO_RP2350_A2_SUPPORTED 0 :) Kind regards, Ralle

lurch (Migrated from github.com) reviewed

2026-07-23 06:16:48 -05:00

src/boards/include/boards/clintech_cpb.h

This line needs fixing 😉

This line needs fixing :wink:

lurch (Migrated from github.com) reviewed

2026-07-23 06:17:06 -05:00

src/boards/include/boards/clintech_cpb.h

...and so do these two.

lurch (Migrated from github.com) reviewed

2026-07-23 06:17:27 -05:00

src/boards/include/boards/clintech_cpb.h

...and this.

lurch (Migrated from github.com) reviewed

2026-07-23 06:17:58 -05:00

src/boards/include/boards/clintech_cpb.h

This also needs to be 0, to match the setting on line 84.

rallepalaveev (Migrated from github.com) reviewed

2026-07-23 12:58:20 -05:00

src/boards/include/boards/clintech_cpb.h

Hello, many thanks for your comments, I have addressed them, I hope correctly.

Would you kindly review and let me know if OK now.

Then, as it seems like the pull request was rejected, do I need to request again?

Thank you.

Ralle.

Hello, many thanks for your comments, I have addressed them, I hope correctly. Would you kindly review and let me know if OK now. Then, as it seems like the pull request was rejected, do I need to request again? Thank you. Ralle.

lurch commented

2026-07-24 06:13:09 -05:00

(Migrated from github.com)

Hello @rallepalaveev , you've just helped me uncover a bug in the check_board_header.py script 😂 It's rejecting board headers that set PICO_RP2350_A2_SUPPORTED to 0, which it shouldn't be doing!
I'll create a PR to fix that, and we'll need to get that PR merged before we can then merge your PR. (So in the meantime, please set PICO_RP2350_A2_SUPPORTED back to 0, don't worry about the failing CI, and then be patient while we fix the check_board_header.py script.)

Hello @rallepalaveev , you've just helped me uncover a bug in the `check_board_header.py` script :joy: It's rejecting board headers that set `PICO_RP2350_A2_SUPPORTED` to 0, which it shouldn't be doing! I'll create a PR to fix that, and we'll need to get that PR merged before we can then merge your PR. (So in the meantime, please set `PICO_RP2350_A2_SUPPORTED` back to 0, don't worry about the failing CI, and then be patient while we fix the `check_board_header.py` script.)

rallepalaveev commented

2026-07-24 09:17:49 -05:00

(Migrated from github.com)

Hi, I am glad I could help by chance though! Reverted the values.

Hi, I am glad I could help by chance though! Reverted the values. R.

👍 1

lurch commented

2026-07-29 04:38:34 -05:00

(Migrated from github.com)

@rallepalaveev #3100 has now been merged, so if you can rebase your PR on top of the latest version of the develop branch, the CI checks should now all pass.

@rallepalaveev #3100 has now been merged, so if you can rebase your PR on top of the latest version of the `develop` branch, the CI checks should now all pass.

rallepalaveev commented

2026-07-29 06:19:46 -05:00

(Migrated from github.com)

Hi,

How do I re-base? Do I need to close this PR and create a new one?

Hi, How do I re-base? Do I need to close this PR and create a new one? R.

lurch commented

2026-07-29 08:59:47 -05:00

(Migrated from github.com)

Do I need to close this PR and create a new one?

That might be the easiest option, yes. But you'll want to sync your develop branch with our develop branch first (see https://docs.github.com/en/pull-requests/how-tos/work-with-forks/syncing-a-fork ), and then you'll want to create the new PR from your develop branch, rather than your master branch.

> Do I need to close this PR and create a new one? That might be the easiest option, yes. But you'll want to sync your `develop` branch with our `develop` branch first (see https://docs.github.com/en/pull-requests/how-tos/work-with-forks/syncing-a-fork ), and then you'll want to create the new PR from your `develop` branch, rather than your `master` branch.

rallepalaveev commented

2026-07-29 10:03:29 -05:00

(Migrated from github.com)

I did a new fork with all branches, including develop, but now I cannot do a pull request. When I do develop to develop, I get an error nothing to compare, although, in my develop branch I have clintech_cpb.h.

I did a new fork with all branches, including develop, but now I cannot do a pull request. When I do `develop` to `develop`, I get an error `nothing to compare`, although, in my `develop` branch I have clintech_cpb.h.

lurch commented

2026-07-29 10:09:14 -05:00

(Migrated from github.com)

I did a new fork with all branches, including develop, but now I cannot do a pull request.

I don't know what you mean by "did a new fork" - did you create a new fork of your existing fork? (If you did, you'd probably be able to PR from your second fork to your first fork, but only your first fork would be able to PR back to this repo?)

I'm afraid that all I can do is point you at GitHub's documentation.

> I did a new fork with all branches, including develop, but now I cannot do a pull request. I don't know what you mean by "did a new fork" - did you create a new fork of your existing fork? (If you did, you'd probably be able to PR from your second fork to your first fork, but only your first fork would be able to PR back to this repo?) I'm afraid that all I can do is point you at [GitHub's documentation](https://docs.github.com/).