WIP: Change source lists for mbedtls #3095

2026-07-23T12:10:51-05:00

peterharperuk commented

2026-07-23 12:10:51 -05:00

(Migrated from github.com)

Currently we list the mbedtls source files in some complicated variables which change depending on the version in use.
This makes it hard to know if you have all the source files needed.

Instead, just copy the source file lists from the mbedtls CMakeLists.txt file into our own included cmake file.
This should reduce the chance of us missing files in future.

See #3081

Currently we list the mbedtls source files in some complicated variables which change depending on the version in use. This makes it hard to know if you have all the source files needed. Instead, just copy the source file lists from the mbedtls CMakeLists.txt file into our own included cmake file. This should reduce the chance of us missing files in future. See #3081

kilograham (Migrated from github.com) reviewed

2026-07-23 12:10:51 -05:00

fink-at-trmc-dk commented

2026-07-24 01:01:55 -05:00

(Migrated from github.com)

Much better approach IMO. I also ran into something similar in LWIP, so maybe this approach could be used there as well?

kilograham commented

2026-07-29 11:29:43 -05:00

(Migrated from github.com)

#3099 is a more generic version of this, which should be used in preference if it works

lurch (Migrated from github.com) reviewed

2026-07-30 02:23:25 -05:00

src/rp2_common/pico_mbedtls/mbedtls_library_2.28.8.cmake

					
				@ -0,0 +1,104 @@

				set(src_crypto

If this PR ends up getting used in preference to #3099 , it'd probably be useful if there was a comment in here saying something like:

# These file-lists were copied from https://github.com/Mbed-TLS/mbedtls/blob/mbedtls-2.28.8/library/CMakeLists.txt

(and similarly for the other files too of course)

If this PR ends up getting used in preference to #3099 , it'd probably be useful if there was a comment in here saying something like: ```cmake # These file-lists were copied from https://github.com/Mbed-TLS/mbedtls/blob/mbedtls-2.28.8/library/CMakeLists.txt ``` (and similarly for the other files too of course)

This pull request has changes conflicting with the target branch.

src/rp2_common/pico_mbedtls/CMakeLists.txt

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'WIP: Change source lists for mbedtls' (#3095) from peterharperuk/change_mbedtls_build into develop

Merge commit body

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/3095

Merge pull request 'WIP: Change source lists for mbedtls' (#3095) from peterharperuk/change_mbedtls_build into develop

Reviewed-on: https://git.richey.dev/gh-raspberrypi/pico-sdk/pulls/3095

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'peterharperuk/change_mbedtls_build:peterharperuk/change_mbedtls_build'

git switch 'peterharperuk/change_mbedtls_build'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'

git merge --no-ff 'peterharperuk/change_mbedtls_build'

git switch 'peterharperuk/change_mbedtls_build'

git rebase 'develop'

git switch 'develop'

git merge --ff-only 'peterharperuk/change_mbedtls_build'

git switch 'peterharperuk/change_mbedtls_build'

git rebase 'develop'

git switch 'develop'

git merge --no-ff 'peterharperuk/change_mbedtls_build'

git switch 'develop'

git merge --squash 'peterharperuk/change_mbedtls_build'