Add -ftls-model=local-exec to embedded builds #3149

2026-08-19T18:39:05-05:00

kilograham commented

2026-08-19 18:39:05 -05:00

(Migrated from github.com)

No description provided.

peterharperuk (Migrated from github.com) reviewed

2026-08-19 18:39:05 -05:00

will-v-pi (Migrated from github.com) reviewed

2026-08-19 18:39:05 -05:00

kilograham commented

2026-08-19 19:58:01 -05:00

(Migrated from github.com)

fixes #3112

Wren6991 (Migrated from github.com) reviewed

2026-08-19 21:05:31 -05:00

test/pico_thread_local_test/pico_thread_local_test_extern.h

					
				@ -0,0 +1,29 @@

				/**

Trying to parse the LLM babble: this seems to insinuate you still get a GOT indirection for TLS in a different TU. I thought the whole point of forcing this TLS model was to not do that, and always emit tp-relative accesses.

Trying to parse the LLM babble: this seems to insinuate you still get a GOT indirection for TLS in a different TU. I thought the whole point of forcing this TLS model was to *not* do that, and always emit `tp`-relative accesses.

lurch (Migrated from github.com) reviewed

2026-08-20 07:59:39 -05:00

bazel/toolchain/BUILD.bazel

					
				@ -56,2 +56,4 @@

				)

				# :tls_local_exec configure local-exec tls model during compilation, so it doesn't use GOT indirection

				cc_args(

It looks like this has been inserted in the wrong place? Line 58 (before this insertion) describes the :no_canonical_system_headers and :no_canonical_prefixes settings, and line 72 (after this insertion) is adding the no_canonical_system_headers setting and line 78 is adding the no_canonical_prefixes setting.

It looks like this has been inserted in the wrong place? Line 58 (before this insertion) describes the `:no_canonical_system_headers` and `:no_canonical_prefixes` settings, and line 72 (after this insertion) is adding the `no_canonical_system_headers` setting and line 78 is adding the `no_canonical_prefixes` setting.

lurch commented

2026-08-20 08:02:41 -05:00

(Migrated from github.com)

What does "embedded builds" mean in this context?

kilograham (Migrated from github.com) reviewed

2026-08-20 17:09:13 -05:00

test/pico_thread_local_test/pico_thread_local_test_extern.h

					
				@ -0,0 +1,29 @@

				/**

it did mention the fact that this only happens with the old tls-model ... but it is something worth testing works anyway - i have modified the comment

kilograham (Migrated from github.com) reviewed

2026-08-20 17:09:29 -05:00

bazel/toolchain/BUILD.bazel

					
				@ -56,2 +56,4 @@

				)

				# :tls_local_exec configure local-exec tls model during compilation, so it doesn't use GOT indirection

				cc_args(

yup i have moved it up

Wren6991 commented

2026-08-20 19:22:58 -05:00

(Migrated from github.com)

What does "embedded builds" mean in this context?

I would guess non-host builds, aka PICO_ON_DEVICE=1

> What does "embedded builds" mean in this context? I would guess non-`host` builds, aka `PICO_ON_DEVICE=1`

Wren6991 (Migrated from github.com) reviewed

2026-08-20 19:23:29 -05:00

test/pico_thread_local_test/pico_thread_local_test_extern.h

					
				@ -0,0 +1,29 @@

				/**

Thanks, the one you wrote is much better.

Wren6991 (Migrated from github.com) approved these changes

2026-08-20 19:23:42 -05:00

lurch (Migrated from github.com) reviewed

2026-08-21 09:05:03 -05:00

test/pico_thread_local_test/pico_thread_local_test.c

					
				@ -26,2 +28,4 @@

				    for (int i=0;i<COUNT;i++) {

				        counter += delta;

				        // the same thing again, but on a thread local this TU only has a declaration for

				        extern_bump(delta);

Was this supposed to be

        counter += extern_bump(delta);

(Or if not, should extern_bump be declared as returning void instead of int?)

Was this supposed to be ```suggestion counter += extern_bump(delta); ``` (Or if not, should `extern_bump` be declared as returning `void` instead of `int`?)

kilograham (Migrated from github.com) reviewed

2026-08-21 15:55:19 -05:00

test/pico_thread_local_test/pico_thread_local_test.c

					
				@ -26,2 +28,4 @@

				    for (int i=0;i<COUNT;i++) {

				        counter += delta;

				        // the same thing again, but on a thread local this TU only has a declaration for

				        extern_bump(delta);