temp workaround for failed build with no PICO_DEFAULT_UART #3171

Merged
kilograham merged 2 commits from low-poer-stdin-uart into develop 2026-09-04 09:27:17 -05:00
kilograham commented 2026-09-03 16:31:17 -05:00 (Migrated from github.com)

Fix broken build when there is no PICO_DEFAULT_UART... note this is a band-aid fix; opening .. #3172 to track

Fix broken build when there is no PICO_DEFAULT_UART... note this is a band-aid fix; opening .. #3172 to track
will-v-pi commented 2026-09-03 16:42:57 -05:00 (Migrated from github.com)

A better fix might be to replace the PICO_DEFAULT_UART references with UART_NUM(uart_default), as other LIB_PICO_STDIO_UART sections rely on uart_default always being defined

A better fix might be to replace the `PICO_DEFAULT_UART` references with `UART_NUM(uart_default)`, as other `LIB_PICO_STDIO_UART` sections rely on `uart_default` always being defined
kilograham commented 2026-09-03 18:01:44 -05:00 (Migrated from github.com)

Well not uart_default is derived from PICO_DEFAULT_UART, but if you are referring to the better fix in the other issue then we can discuss there

Well not uart_default is derived from PICO_DEFAULT_UART, but if you are referring to the better fix in the other issue then we can discuss there
will-v-pi (Migrated from github.com) reviewed 2026-09-04 05:25:51 -05:00
will-v-pi commented 2026-09-04 05:27:58 -05:00 (Migrated from github.com)

A better fix might be to replace the PICO_DEFAULT_UART references with UART_NUM(uart_default), as other LIB_PICO_STDIO_UART sections rely on uart_default always being defined

I got confused - I thought uart_default was being used without #ifdef uart_default in stdio_uart_init, but had just misread it

> A better fix might be to replace the `PICO_DEFAULT_UART` references with `UART_NUM(uart_default)`, as other `LIB_PICO_STDIO_UART` sections rely on `uart_default` always being defined I got confused - I thought `uart_default` was being used without `#ifdef uart_default` in `stdio_uart_init`, but had just misread it
will-v-pi (Migrated from github.com) approved these changes 2026-09-04 05:28:07 -05:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!3171
No description provided.