Some code in the "common" libraries is incompatible with MSVC #435

New issue

Open

opened 2021-05-22 18:05:59 -05:00 by jonathangjertsen · 2 comments

jonathangjertsen commented

2021-05-22 18:05:59 -05:00

(Migrated from github.com)

I encountered some issues while trying to build parts of the pico sdk for MSVC (for host-based unit testing):

using the invalid_params_if, valid_params_if, hard_assert_if macros triggers errors like [...]\pico-sdk\src\host\hardware_timer\include\hardware/timer.h(22): error C2059: syntax error: '{'
auto_init_mutex uses __attribute__ which is a GCC extension
sem_available uses typeof which is a GCC extension
hw_divider_result_threadlocal is declared with __thread, but platform.h (which defines __thread) is not included by the header file

I have workarounds for these issues in github.com/jonathangjertsen/pico-sdk@0fa7da92df, but they are hacks and only cover the parts I used in my application. A quick search through the code base reveals many other usages of GCC extensions under the "common" code.

To what extent is building for host with MSVC supported? It seems like at least some support was intended at some point, since there are a couple of checks for _MSC_VER.

I encountered some issues while trying to build parts of the pico sdk for MSVC (for host-based unit testing): * using the `invalid_params_if`, `valid_params_if`, `hard_assert_if` macros triggers errors like `[...]\pico-sdk\src\host\hardware_timer\include\hardware/timer.h(22): error C2059: syntax error: '{'` * `auto_init_mutex` uses `__attribute__` which is a GCC extension * `sem_available` uses `typeof` which is a GCC extension * `hw_divider_result_threadlocal` is declared with `__thread`, but `platform.h` (which defines `__thread`) is not included by the header file I have workarounds for these issues in https://github.com/jonathangjertsen/pico-sdk/commit/0fa7da92dffa83500faba3c32faaff1de2049efd, but they are hacks and only cover the parts I used in my application. A quick search through the code base reveals many other usages of GCC extensions under the "common" code. To what extent is building for host with MSVC supported? It seems like at least some support was intended at some point, since there are a couple of checks for `_MSC_VER`.

kilograham commented

2021-05-23 08:16:38 -05:00

(Migrated from github.com)

Yeah it isn't really supported atm as (as you saw) started down that route, but there are a bunch of (as you say non-trivial) issues; hoping that gcc is a reasonable workaround on WIndows, but happy to accept PRs to fix either, we just don't have any resources to spend on it atm.

Rows
Columns