gh-raspberrypi/pico-sdk

Watch

Add adc_irq_set_enabled_with_callback or similar #452

New issue

Open

opened 2021-05-27 04:30:22 -05:00 by jonathangjertsen · 1 comment

jonathangjertsen commented

2021-05-27 04:30:22 -05:00

(Migrated from github.com)

The ADC module could use a function to set up an interrupt handler for the ADC FIFO interrupt, in a similar fashion to what the GPIO module does. Also: there is a function adc_irq_set_enabled, but it only sets the interrupt enable flag in the ADC module. Should it call irq_set_enabled as well?

The ADC module could use a function to set up an interrupt handler for the ADC FIFO interrupt, in a similar fashion to what the GPIO module does. Also: there is a function `adc_irq_set_enabled`, but it only sets the interrupt enable flag in the ADC module. Should it call `irq_set_enabled` as well?

bruelltuete commented

2022-04-12 09:55:36 -05:00

(Migrated from github.com)

[...] Also: there is a function adc_irq_set_enabled, but it only sets the interrupt enable flag in the ADC module. Should it call irq_set_enabled as well?

I would say no, it shouldn't. ADC and IRQ are two separate things. And enabling the IRQ for a given core should be up to you.

> [...] Also: there is a function `adc_irq_set_enabled`, but it only sets the interrupt enable flag in the ADC module. Should it call `irq_set_enabled` as well? I would say no, it shouldn't. ADC and IRQ are two separate things. And enabling the IRQ for a given core should be up to you.

Sign in to join this conversation.

No labels

can't reproduce

code cleanliness

compiler version issues

hardware_clocks

hardware_exception

hardware_watchdog

needs reporter detail

newlib-multicore

pico_async_context

pico_binary_info

wifi integration

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk#452

No description provided.