add CONTRIBUTING.md #626

Merged
kilograham merged 6 commits from contributing.md into develop 2021-10-26 13:44:03 -05:00
kilograham commented 2021-10-22 14:30:18 -05:00 (Migrated from github.com)
No description provided.
ghollingworth (Migrated from github.com) reviewed 2021-10-22 14:30:18 -05:00
lurch (Migrated from github.com) reviewed 2021-10-25 05:33:07 -05:00
@ -0,0 +1,25 @@
# Contributing to Raspberry Pi Pico C/C++ SDK
lurch (Migrated from github.com) commented 2021-10-25 05:33:07 -05:00

"ideally a some code" -> "ideally some code"

"ideally a some code" -> "ideally some code"
lurch (Migrated from github.com) reviewed 2021-10-25 05:36:02 -05:00
@ -0,0 +1,25 @@
# Contributing to Raspberry Pi Pico C/C++ SDK
lurch (Migrated from github.com) commented 2021-10-25 05:36:02 -05:00

Could mention space between ) and { ? 🤷

Could mention space between `)` and `{` ? :shrug:
kilograham (Migrated from github.com) reviewed 2021-10-25 08:38:34 -05:00
@ -0,0 +1,25 @@
# Contributing to Raspberry Pi Pico C/C++ SDK
kilograham (Migrated from github.com) commented 2021-10-25 08:38:33 -05:00

yeah, not feeling like listing everything right now - i think "match existing" covers it

yeah, not feeling like listing everything right now - i think "match existing" covers it
aallan commented 2021-10-25 13:26:02 -05:00 (Migrated from github.com)

@kilograham You might want to restructure it somewhat, see for instance the CONTRIBUTING.md file in the documentation repo. There we have an introduction, instructions on how we want you to contribute, the definition of the type of content we want, and then the content we don't want, and a reminder about what licensing it's going to be under.

@kilograham You might want to restructure it somewhat, see for instance the [CONTRIBUTING.md](https://github.com/raspberrypi/documentation/blob/develop/CONTRIBUTING.md) file in the documentation repo. There we have an introduction, instructions on how we want you to contribute, the definition of the type of content we want, and then the content we don't want, and a reminder about what licensing it's going to be under.
aallan commented 2021-10-25 14:14:11 -05:00 (Migrated from github.com)

@kilograham I've redrafted based on our email discussion. Hope that suits? It now (somewhat) mirrors the documentation repo version.

@kilograham I've redrafted based on our email discussion. Hope that suits? It now (somewhat) mirrors the documentation repo version.
aallan (Migrated from github.com) reviewed 2021-10-25 14:18:57 -05:00
kilograham commented 2021-10-25 17:58:14 -05:00 (Migrated from github.com)

i removed "pico pico", but also remove the first paragraph since that sort of stuff is already in the README

i removed "pico pico", but also remove the first paragraph since that sort of stuff is already in the README
lurch (Migrated from github.com) reviewed 2021-10-25 19:22:58 -05:00
@ -0,0 +1,25 @@
# Contributing to Raspberry Pi Pico C/C++ SDK
lurch (Migrated from github.com) commented 2021-10-25 19:22:58 -05:00

Should be "Raspberry Pi Pico C/C++ SDK"

Should be "Raspberry Pi Pico C/C++ SDK"
lurch commented 2021-10-25 19:27:01 -05:00 (Migrated from github.com)

"In order to contribute new or updated code, you must first create a GitHub account..."

Seems likely that the people with the technical ability to be submitting SDK PRs, will also be technical enough to already have a GitHub account? 🤷

"In order to contribute new or updated code, you must first create a GitHub account..." Seems likely that the people with the technical ability to be submitting SDK PRs, will also be technical enough to already have a GitHub account? :shrug:
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!626
No description provided.