__aeabi_memset implementation swaps wrong arguments #633

New issue

Closed

opened 2021-10-26 11:17:30 -05:00 by kilograham · 1 comment

kilograham commented 2021-10-26 11:17:30 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

memset and __aeabi_memset have second and third parameters in the opposite order.

our pico_mem_ops __aeabi_memset implementation swaps the order before calling the bootrom __memset which has the memset ordering.

Foolishly, the implemention swaps first and second parameters not second and third.

This went unnoticed as the testcase used memset, but GCC always inlines this rather than calling __aeabi_memset

`memset` and `__aeabi_memset` have second and third parameters in the opposite order. our `pico_mem_ops` `__aeabi_memset` implementation swaps the order before calling the bootrom `__memset` which has the `memset` ordering. Foolishly, the implemention swaps first and second parameters not second and third. This went unnoticed as the testcase used memset, but GCC _always_ inlines this rather than calling `__aeabi_memset`

kilograham commented 2021-10-28 15:17:17 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

merged into develop

merged into develop

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

rpi-connect-preview

ns-alpha

combine-uf2s

powman-fixups

persistent-data-docs

develop

aon-docs-fix

default-uart-fixups

async-context-deinit-freertos

sdk-time-critical

riscv-flag-check

multi-gcc-riscv-scrict-align

multi-gcc-develop

another-sleep-fix

powman-default-tick

bootrom_sysinfo_tweaks

board_header_checks

mbedtls-file-lists

use_count_of

vtable-per-core

stdio-usb-reset-compat

pico-aes

better-package

ditch_pico_pio_version

ns-develop

hardware-header-updates

low-power-ci

pioasm-cflags

lurch-patch-4

lurch-patch-3

rom_version

iar/develop

2.3.1

2.3.0

2.2.0

2.1.0-correct-picotool

2.1.1-correct-picotool

2.1.1

2.1.0

2.0.0

1.5.1

1.5.0

1.4.0

1.3.1

1.3.0

1.2.0

1.1.2

1.1.1

1.1.0

1.0.1

1.0.0

Labels

Clear labels   

bazel

  

bluetooth

  

board settings

  

boot_stage2

  

bug

Something isn't working

  

build

  

c++

  

can't reproduce

Can not reproduce the bug

  

clang

  

clib-interface

  

cmsis

  

code cleanliness

  

code size

  

compiler version issues

  

cyw43_driver

  

debug

  

discussion

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

dynamic_clock

  

elf2uf2

  

enhancement

New feature or request

  

errata

  

filesystem

  

flash layout

  

floating point

  

FreeRTOS

  

hardware_adc

  

hardware_claim

  

hardware_clocks

  

hardware_dma

  

hardware_exception

  

hardware_flash

  

hardware_gpio

  

hardware_i2c

  

hardware_irq

  

hardware_pio

  

hardware_pwm

  

hardware_rcp

  

hardware_rtc

  

hardware_spi

  

hardware_sync

  

hardware_uart

  

hardware_vreg

  

hardware_watchdog

  

hardware_xosc

  

help wanted

Extra attention is needed

  

host

  

IAR

  

installation

  

invalid

This doesn't seem right

  

linker scripts

  

lto

  

lwip

  

mbedtls

  

missing API

  

needs reporter detail

  

networking

  

newlib

  

newlib-multicore

  

non-c

  

non-cmake

  

non-gcc

  

openocd

  

orphan PR

  

OS integration

  

pico_async_context

  

pico_base

  

pico_binary_info

  

pico_flash

  

picolibc

  

pico_lwip

  

pico_malloc

  

pico_multicore

  

pico_printf

  

pico_runtime

  

pico_stdio

  

pico_stdio_usb

  

pico_sync

  

pico_time

  

pico_util

  

pioasm

  

port

issues or discussions of porting code/libraries to rp2040

  

question

Further information is requested

  

review

  

review2

  

rtos interop

Consideration for FreeRTOS co-existence

  

runtime init

  

static library

  

svd

  

test

  

tinyusb

  

vscode

  

wifi integration

  

wontfix

This will not be worked on

No labels

bazel

bluetooth

board settings

boot_stage2

bug

build

c++

can't reproduce

clang

clib-interface

cmsis

code cleanliness

code size

compiler version issues

cyw43_driver

debug

discussion

documentation

duplicate

dynamic_clock

elf2uf2

enhancement

errata

filesystem

flash layout

floating point

FreeRTOS

hardware_adc

hardware_claim

hardware_clocks

hardware_dma

hardware_exception

hardware_flash

hardware_gpio

hardware_i2c

hardware_irq

hardware_pio

hardware_pwm

hardware_rcp

hardware_rtc

hardware_spi

hardware_sync

hardware_uart

hardware_vreg

hardware_watchdog

hardware_xosc

help wanted

host

IAR

installation

invalid

linker scripts

lto

lwip

mbedtls

missing API

needs reporter detail

networking

newlib

newlib-multicore

non-c

non-cmake

non-gcc

openocd

orphan PR

OS integration

pico_async_context

pico_base

pico_binary_info

pico_flash

picolibc

pico_lwip

pico_malloc

pico_multicore

pico_printf

pico_runtime

pico_stdio

pico_stdio_usb

pico_sync

pico_time

pico_util

pioasm

port

question

review

review2

rtos interop

runtime init

static library

svd

test

tinyusb

vscode

wifi integration

wontfix

Milestone

Clear milestone

No items

No milestone

1.3.0

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk#633

No description provided.