Add board definition for RP2040 Stamp #696

2022-01-03T10:42:40-06:00

arturo182 commented

2022-01-03 10:42:40 -06:00

(Migrated from github.com)

More details about the board available here: https://rp2040-stamp.solder.party/

👍 1

rivimey (Migrated from github.com) requested changes

2022-01-03 12:45:10 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

Change the copyright date to 2021?

My version of this was:

// no PICO_DEFAULT_LED_PIN
// WS2812 can be jumpered out of circuit (JP1/JP2).
#ifndef PICO_NO_WS2812
#ifndef PICO_DEFAULT_WS2812_PIN
#define PICO_DEFAULT_WS2812_PIN 21
#endif
#endif // PICO_NO_WS2812

I decided not to set 'LED PIN' because it's only on the carrier, not the stamp itself.

My version of this was: ``` // no PICO_DEFAULT_LED_PIN // WS2812 can be jumpered out of circuit (JP1/JP2). #ifndef PICO_NO_WS2812 #ifndef PICO_DEFAULT_WS2812_PIN #define PICO_DEFAULT_WS2812_PIN 21 #endif #endif // PICO_NO_WS2812 ``` I decided not to set 'LED PIN' because it's only on the carrier, not the stamp itself.

arturo182 (Migrated from github.com) reviewed

2022-01-03 16:04:38 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

TBH most of these are specific to the Carrier, the Stamp itself can use any pin for any function (that the RP2040 allows), but the defaults are those that are used by the Carrier cause for many people that will be their entry point :)

kilograham (Migrated from github.com) reviewed

2022-01-08 13:46:51 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

r you sure you want this?

rivimey (Migrated from github.com) reviewed

2022-01-08 14:13:08 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

I would personally think that this board definition should be specific to the stamp on its own; if the carrier adds useful things to that then IMO it should be another board.

While I am aware that the stamp can use any pin, the point of these definitions is to provide sane defaults for the various examples and a good basis for building a project on top of it, so defining things which are not available unless you have a carrier board is not helpful.

I would personally think that this board definition should be specific to the stamp on its own; if the carrier adds useful things to that then IMO it should be another board. While I am aware that the stamp can use any pin, the point of these definitions is to provide sane defaults for the various examples and a good basis for building a project on top of it, so defining things which are not available unless you have a carrier board is not helpful.

rivimey (Migrated from github.com) reviewed

2022-01-08 14:14:13 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

I noticed this difference from the version I made (copied from another board) and presumed it was intended. Can you elaborate on what the difference actually means?

kilograham (Migrated from github.com) reviewed

2022-01-08 20:05:20 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

Yes, there should probably be a separate header for the carrier board that (pre) overrides anything it needs to, and includes the stamp header at the end to pick up the rest of the defaults

kilograham (Migrated from github.com) reviewed

2022-01-08 20:07:36 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

This select the slow generic flash stage2 boot, which is probably only what you want if a faster specific variant does not work. I'm pretty sure the stage2 boot used on the pico worked on the stamp too (when i tried it), but @arturo182 would know better

This select the *slow* generic flash stage2 boot, which is probably only what you want if a faster specific variant does not work. I'm pretty sure the stage2 boot used on the pico worked on the stamp too (when i tried it), but @arturo182 would know better

arturo182 (Migrated from github.com) reviewed

2022-01-08 20:40:01 -06:00

src/boards/include/boards/solderparty_rp2040_stamp.h

					
				@ -0,0 +1,83 @@

				/*

I was not able to get any other variant working for the production GD25Q64 flash. IIRC I sent you one stamp with that flash and one with Winbond, which did you use? I will retest all other defs one more time to verify.

kilograham commented

2022-01-09 16:48:13 -06:00

(Migrated from github.com)

hello.zip
Yeah i tried with the GDw5q64 version.. here is a little UF2 i just tried with (which for my test purposes both has boot2_w25q080 and ups the clock speed to 270Mhz)... it prints stuff to USB console

[hello.zip](https://github.com/raspberrypi/pico-sdk/files/7836138/hello.zip) Yeah i tried with the GDw5q64 version.. here is a little UF2 i just tried with (which for my test purposes both has boot2_w25q080 and ups the clock speed to 270Mhz)... it prints stuff to USB console

arturo182 commented

2022-01-11 15:30:58 -06:00

(Migrated from github.com)