Add PICO_NO_FPGA_CHECK define to remove FPGA check and save some bytes #78

Merged
Wren6991 merged 1 commit from fpga-check-config into develop 2021-02-04 05:16:56 -06:00
Wren6991 commented 2021-02-03 06:47:44 -06:00 (Migrated from github.com)

See https://github.com/raspberrypi/pico-sdk/issues/72

We want to leave this check in by default, but it is called (outline call) in 3 places, so adds a total of 48 bytes to the binary. This commit adds a PICO_NO_FPGA_CHECK config to replace the code with an inline stub, so that the calls get folded away.

I added the config to the pico_runtime group as that is what it affects. Noticed that platform.h is also a bit light on doxygen, so @kilograham I can add some doxygen there as part of this PR, and add this config to a new pico_platform doxygen group. Lmk

See https://github.com/raspberrypi/pico-sdk/issues/72 We want to leave this check in by default, but it is called (outline call) in 3 places, so adds a total of 48 bytes to the binary. This commit adds a PICO_NO_FPGA_CHECK config to replace the code with an inline stub, so that the calls get folded away. I added the config to the `pico_runtime` group as that is what it affects. Noticed that `platform.h` is also a bit light on doxygen, so @kilograham I can add some doxygen there as part of this PR, and add this config to a new `pico_platform` doxygen group. Lmk
SteveGotthardt (Migrated from github.com) approved these changes 2021-02-03 11:17:44 -06:00
SteveGotthardt (Migrated from github.com) left a comment

Good solution. Thanks

Good solution. Thanks
kilograham (Migrated from github.com) approved these changes 2021-02-03 14:33:36 -06:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-raspberrypi/pico-sdk!78
No description provided.