Pad all but last sector in flash binary to write whole of sector #800

2022-05-03T13:44:15-05:00

kilograham commented

2022-05-03 13:44:15 -05:00

(Migrated from github.com)

Additional changes on top of #763

lurch (Migrated from github.com) reviewed

2022-05-04 04:27:10 -05:00

tools/elf2uf2/main.cpp

					
				@ -296,0 +315,4 @@

				                    // Create a dummy page, if it does not exist yet. note that all present pages are first

				                    // zeroed before they are filled with any contents, so a dummy page will be all zeros.

				                    auto &dummy = pages[page];

				                }

For this last sector, it makes sense that we don't want/need to add any zero-padding after the data in that sector; but do any holes before the data in the last sector still need to be filled with zeroes?

For this last sector, it makes sense that we don't want/need to add any zero-padding _after_ the data in that sector; but do any holes _before_ the data in the last sector still need to be filled with zeroes?

kilograham (Migrated from github.com) reviewed

2022-05-04 11:20:49 -05:00

tools/elf2uf2/main.cpp

					
				@ -296,0 +315,4 @@

				                    // Create a dummy page, if it does not exist yet. note that all present pages are first

				                    // zeroed before they are filled with any contents, so a dummy page will be all zeros.

				                    auto &dummy = pages[page];

				                }

good point :-)

kilograham (Migrated from github.com) reviewed

2022-05-04 12:59:01 -05:00

tools/elf2uf2/main.cpp

					
				@ -296,0 +315,4 @@

				                    // Create a dummy page, if it does not exist yet. note that all present pages are first

				                    // zeroed before they are filled with any contents, so a dummy page will be all zeros.

				                    auto &dummy = pages[page];

				                }

actually it doesn't matter from a correctness point of view (the actual data of the last sector will be written correctly), however as it stands a gap in the last sector will not be filled with zeroes.

Rows
Columns