Remove logger shutdown #117

New issue

Closed

opened 2017-05-19 14:39:01 -05:00 by alexcrichton · 2 comments

alexcrichton commented

2017-05-19 14:39:01 -05:00

(Migrated from github.com)

This adds some complexity to the logger plus extra cost on all logger calls. In our discussion of this issue the review team also concluded that it would be prudent to maybe add a top-level flushing method to explicitly ensure that a common part of shutdown, flushing, can still be manually performed. Flushing would be a noop by default.

pittma commented

2017-06-01 18:18:01 -05:00

(Migrated from github.com)

Hi all,

I'm interested in diving into this one, but I could use a little guidance. Is this about exposing a flush, or removing shutdown? Or, rather, is it about removing the state (and therefore the check) from the logger's state machine?

Thanks!

Hi all, I'm interested in diving into this one, but I could use a little guidance. Is this about exposing a `flush`, or removing `shutdown`? Or, rather, is it about removing the state (and therefore the check) from the logger's state machine? Thanks!

sfackler commented

2017-06-01 18:30:43 -05:00

(Migrated from github.com)

All of the above! Removing shutdown allows https://github.com/rust-lang-nursery/log/blob/master/src/lib.rs#L264 and the related logic to go away. Flush is just a new method on Log with a default implementation.