set_logger doc improvements

alexcrichton commented

2017-05-19 14:48:04 -05:00

(Migrated from github.com)

Add links
Add "Errors" section
Add example

- Add links - Add "Errors" section - Add example

alexcrichton commented

2017-05-19 15:00:17 -05:00

(Migrated from github.com)

We should also clarify the error conditions here to mention there's no memory unsafety, but also clearly state what the error conditions are.

rap2hpoutre commented

2017-05-30 04:24:07 -05:00

(Migrated from github.com)

@alexcrichton I already wrote (helped by rustaceans!) an example of use of set_logger for the cookbook here: https://brson.github.io/rust-cookbook/logging.html#log-messages-with-a-custom-logger

Do you think we have to write a new different one? Or "copy/pasting" this one is OK? Maybe we should make a shorter example, but I don't know what to remove.

@alexcrichton I already wrote (helped by rustaceans!) an example of use of `set_logger` for the cookbook here: https://brson.github.io/rust-cookbook/logging.html#log-messages-with-a-custom-logger Do you think we have to write a new different one? Or "copy/pasting" this one is OK? Maybe we should make a shorter example, but I don't know what to remove.

alexcrichton commented

2017-05-30 09:35:26 -05:00

(Migrated from github.com)

@rap2hpoutre nah copy/pasting sounds great! No need to create more work when it's already done :)

rap2hpoutre commented

2017-06-01 07:23:59 -05:00

(Migrated from github.com)

@alexcrichton Ok done for the example part! see: https://github.com/rust-lang-nursery/log/pull/186

alexcrichton commented

2017-06-01 13:38:26 -05:00

(Migrated from github.com)

Awesome! In that case closing.

budziq commented

2017-06-02 15:15:25 -05:00

(Migrated from github.com)

@alexcrichton hi I would reopen as set_logger doc still misses links and errors section

Rows
Columns

set_logger doc improvements #135