Reduce "stuttering" in types #142

Closed
opened 2017-05-19 14:53:19 -05:00 by alexcrichton · 3 comments
alexcrichton commented 2017-05-19 14:53:19 -05:00 (Migrated from github.com)

Rename types like log::LogRecord to log::Record

Rename types like `log::LogRecord` to `log::Record`
ottaviohartman commented 2017-05-20 16:32:32 -05:00 (Migrated from github.com)

I'd like to try working on this.

To confirm:
LogLevel -> Level
LogLevelFilter -> LevelFilter
LogRecord -> Record
LogMetadata -> Metadata, etc.?

Just types? What about functions like log::LogLevel::to_log_level_filter()? Should it become log::Level::to_level_filter?

Should MaxLogLevelFilter become MaxLevelFilter?

I'd like to try working on this. To confirm: `LogLevel` -> `Level` `LogLevelFilter` -> `LevelFilter` `LogRecord` -> `Record` `LogMetadata` -> `Metadata`, etc.? Just types? What about functions like `log::LogLevel::to_log_level_filter()`? Should it become `log::Level::to_level_filter`? Should `MaxLogLevelFilter` become `MaxLevelFilter`?
alexcrichton commented 2017-05-21 10:23:35 -05:00 (Migrated from github.com)

That all sounds great to me @omh1280! @sfackler does anything else come to mind for you?

That all sounds great to me @omh1280! @sfackler does anything else come to mind for you?
sfackler commented 2017-05-22 11:25:30 -05:00 (Migrated from github.com)

That's everything I can think of. I would agree that the functions and MaxLogLevelFilter would be renamed as well.

That's everything I can think of. I would agree that the functions and `MaxLogLevelFilter` would be renamed as well.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-rust-lang/log#142
No description provided.