URL doesn't respect language #1

New issue

Open

opened 2019-03-14 07:45:47 -05:00 by Traumflug · 0 comments

Traumflug commented

2019-03-14 07:45:47 -05:00

(Migrated from github.com)

See here: https://forum.thirtybees.com/topic/2708-block-facebook-hardcoded-english-language/

blockfacebook.js has hardcoded English language setting for Facebook block. I've hacked it by hand, but ideal would be fixing it, so it will work well with multilanguage sites. just need to pass selected language iso code needed to create proper facebook js script link - any suggestions how it could be done?

js.src = "//connect.facebook.net/$ISO_CODE_HERE/sdk.js#xfbml=1&version=v3.2";

$(document).ready(function() {
	initfb(document, 'script', 'facebook-jssdk');
});

function initfb(d, s, id)
{
	var js, fjs = d.getElementsByTagName(s)[0];
	if (d.getElementById(id))
		return;
	js = d.createElement(s); js.id = id;
	js.src = "//connect.facebook.net/en_US/all.js#xfbml=1&appId=334341610034299";
	fjs.parentNode.insertBefore(js, fjs);
}

See here: https://forum.thirtybees.com/topic/2708-block-facebook-hardcoded-english-language/ ---- blockfacebook.js has hardcoded English language setting for Facebook block. I've hacked it by hand, but ideal would be fixing it, so it will work well with multilanguage sites. just need to pass selected language iso code needed to create proper facebook js script link - any suggestions how it could be done? ``` javascript js.src = "//connect.facebook.net/$ISO_CODE_HERE/sdk.js#xfbml=1&version=v3.2"; ``` ``` javascript $(document).ready(function() { initfb(document, 'script', 'facebook-jssdk'); }); function initfb(d, s, id) { var js, fjs = d.getElementsByTagName(s)[0]; if (d.getElementById(id)) return; js = d.createElement(s); js.id = id; js.src = "//connect.facebook.net/en_US/all.js#xfbml=1&appId=334341610034299"; fjs.parentNode.insertBefore(js, fjs); } ```