Overrides are not work for errors. Please can you make public variable, instead of private #8

New issue

Closed

opened 2022-12-15 09:30:01 -06:00 by uguranium · 0 comments

uguranium commented

2022-12-15 09:30:01 -06:00

(Migrated from github.com)

I have overridden class for blocknewsletter.

class BlocknewsletterOverride extends Blocknewsletter

There $this->error and $this->valid is not work. Please can you change it from:

private $error;
private $valid;

public $error;
public $valid;

Also comment line for error can be bool | string I think (instead of var bool)

Thank you.

I have overridden class for blocknewsletter. `class BlocknewsletterOverride extends Blocknewsletter` There `$this->error` and `$this->valid` is not work. Please can you change it from: private $error; private $valid; to public $error; public $valid; Also comment line for error can be bool | string I think (instead of var bool) Thank you.