Available quantities - pack should not add pack products to the total. #28

Closed
opened 2024-11-19 16:01:24 -06:00 by therampagerado · 2 comments
therampagerado commented 2024-11-19 16:01:24 -06:00 (Migrated from github.com)

Currently when we have a pack of products its value is added to the total twice - once as singular item and once in a pack.

It would be nice if this tab detects pack products and exclude their value. I'm not sure if it should still show their 'Available quantity for sale'. Probably should display '-' as this quantity is not very informative and should not be included in this list.

Currently when we have a pack of products its value is added to the total twice - once as singular item and once in a pack. It would be nice if this tab detects pack products and exclude their value. I'm not sure if it should still show their 'Available quantity for sale'. Probably should display '-' as this quantity is not very informative and should not be included in this list.
therampagerado commented 2024-11-20 09:57:41 -06:00 (Migrated from github.com)

@getdatakick, if you think that this change should be implemented for price column too I'll make another PR.

@getdatakick, if you think that this change should be implemented for price column too I'll make another PR.
getdatakick commented 2024-11-20 11:56:27 -06:00 (Migrated from github.com)

Thank you for the PR, I've merged it.

I don't think price column should be modified, I think it's ok to roll up the price of packs into average price of catalog

Thank you for the PR, I've merged it. I don't think price column should be modified, I think it's ok to roll up the price of packs into average price of catalog
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-thirtybees/statsmodule#28
No description provided.