Exclude example and tool #61

New issue

Closed

opened 2018-10-13 22:57:30 -05:00 by ghuser404 · 2 comments

ghuser404 commented

2018-10-13 22:57:30 -05:00

(Migrated from github.com)

Add CMake options to exclude example and tool.

jpetso commented

2018-10-14 13:00:44 -05:00

(Migrated from github.com)

Related to issue #60, where I imply that the CMakeLists.txt are only meant for internal usage (tests, examples, tools) and not meant to be included by another CMake directory.

I can see how excluding examples can be helpful if one just wants the tools - maybe this should be lumped together with the BUILD_TESTING flag?

I can't see how excluding the tools directory would make sense in any use case. They're good for testing and good for distribution, and people who just use the header-only library would ignore it by simply adding the root as include directory, without adding the project's CMakeLists.txt as a dependency.

Related to issue #60, where I imply that the CMakeLists.txt are only meant for internal usage (tests, examples, tools) and not meant to be included by another CMake directory. I can see how excluding examples can be helpful if one just wants the tools - maybe this should be lumped together with the BUILD_TESTING flag? I can't see how excluding the tools directory would make sense in any use case. They're good for testing and good for distribution, and people who just use the header-only library would ignore it by simply adding the root as include directory, without adding the project's CMakeLists.txt as a dependency.

ghuser404 commented

2018-10-14 17:06:17 -05:00

(Migrated from github.com)

I can only say from point of view of a user who would be including the library as a subproject (with target_link_libraries). If that is not an option with this library, according to your answer in #60, then there is no need for this issue.

I can only say from point of view of a user who would be including the library as a subproject (with `target_link_libraries`). If that is not an option with this library, according to your answer in #60, then there is no need for this issue.