Clippy #163

2018-03-04T18:09:54-06:00

kinggoesgaming commented

2018-03-04 18:09:54 -06:00

(Migrated from github.com)

~~This is declared a breaking change as per clippy requesting that Hash be derived, as @Dylan-DPC asked.~~

![image](https://user-images.githubusercontent.com/15664607/36952547-48806ef8-1fc6-11e8-8c1d-729dcce2c339.png) ~~This is declared a breaking change as per clippy requesting that `Hash` be derived, as @Dylan-DPC asked.~~

radix (Migrated from github.com) reviewed

2018-03-04 18:09:54 -06:00

KodrAus commented

2018-03-04 18:15:41 -06:00

(Migrated from github.com)

@kinggoesgaming Deriving Hash shouldn't be a breaking change, especially since it was already implemented before.

@kinggoesgaming Deriving `Hash` shouldn't be a breaking change, especially since it was already implemented before.

KodrAus (Migrated from github.com) reviewed

2018-03-04 18:16:50 -06:00

src/lib.rs

					
				@ -995,12 +997,6 @@ impl fmt::LowerHex for Uuid {

				    }

We can probably just remove this commented out code.

kinggoesgaming (Migrated from github.com) reviewed

2018-03-04 18:26:46 -06:00

src/lib.rs

					
				@ -995,12 +997,6 @@ impl fmt::LowerHex for Uuid {

				    }

oops

kinggoesgaming commented

2018-03-04 18:27:17 -06:00

(Migrated from github.com)

Right I will re-target it to master

Right I will re-target it to `master`

KodrAus (Migrated from github.com) approved these changes

2018-03-04 18:51:12 -06:00

KodrAus (Migrated from github.com) left a comment

This looks good to me!

Dylan-DPC-zz commented

2018-03-05 01:47:56 -06:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-03-05 03:17:57 -06:00

(Migrated from github.com)

Timed out

# Timed out

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-03-05 04:16:46 -06:00

Dylan-DPC-zz commented

2018-03-05 04:17:10 -06:00

(Migrated from github.com)

bors: try

bors[bot] commented

2018-03-05 04:17:10 -06:00

(Migrated from github.com)

try

Not awaiting review

## try Not awaiting review

Dylan-DPC-zz commented

2018-03-05 04:17:37 -06:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-03-05 04:35:52 -06:00

(Migrated from github.com)

try

Build succeeded

## try # Build succeeded * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/349220444?utm_source=github_status&utm_medium=notification) * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.199)

bors[bot] commented

2018-03-05 04:45:10 -06:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.200) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/349220961?utm_source=github_status&utm_medium=notification)

Sign in to join this conversation.

No reviewers

radix

KodrAus

Dylan-DPC-zz