Add Nil variant #181

2018-03-20T22:30:27-05:00

kinggoesgaming commented

2018-03-20 22:30:27 -05:00

(Migrated from github.com)

I'm submitting a ...

bug fix
feature enhancement
deprecation or removal
refactor

Description

Adds Nil variant to the UuidVersion.

Motivation

nil Uuid, containing all zeros, is a valid Uuid, as per the specification. This will allow users doing pattern matching to explicitly check for it.

Tests

Updated test_nil to ensure that

closes #133
supersedes #176

**I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Adds `Nil` variant to the `UuidVersion`. # Motivation `nil` `Uuid`, containing all zeros, is a valid `Uuid`, as per the specification. This will allow users doing pattern matching to explicitly check for it. # Tests Updated `test_nil` to ensure that # Related Issue(s) closes #133 supersedes #176

radix (Migrated from github.com) reviewed

2018-03-20 22:30:27 -05:00

Dylan-DPC-zz (Migrated from github.com) reviewed

2018-03-21 17:07:58 -05:00

KodrAus (Migrated from github.com) reviewed

2018-03-21 17:43:22 -05:00

KodrAus (Migrated from github.com) left a comment

No description provided.

Looks good to me!

KodrAus (Migrated from github.com) reviewed

2018-03-22 17:40:09 -05:00

src/lib.rs

					
				@ -151,6 +151,10 @@ pub type UuidBytes = [u8; 16];

				/// The version of the UUID, denoting the generating algorithm.

What do we have the [struct.Uuid.html] here for? Does this render in the docs as struct.Uuid.html?

What do we have the [`struct.Uuid.html`] here for? Does this render in the docs as `struct.Uuid.html`?

kinggoesgaming (Migrated from github.com) reviewed

2018-03-23 10:16:49 -05:00

src/lib.rs

					
				@ -151,6 +151,10 @@ pub type UuidBytes = [u8; 16];

				/// The version of the UUID, denoting the generating algorithm.

Woops I forgot to link it will fix it ASAP

kinggoesgaming (Migrated from github.com) reviewed

2018-03-23 10:19:17 -05:00

src/lib.rs

					
				@ -151,6 +151,10 @@ pub type UuidBytes = [u8; 16];

				/// The version of the UUID, denoting the generating algorithm.

That was supposed to be Uuid

That was supposed to be [`Uuid`](struct.Uuid.html)

kinggoesgaming (Migrated from github.com) reviewed

2018-03-24 22:38:52 -05:00

src/lib.rs

					
				@ -151,6 +151,10 @@ pub type UuidBytes = [u8; 16];

				/// The version of the UUID, denoting the generating algorithm.

@KodrAus fixed.. can you approve

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-03-25 14:06:06 -05:00

KodrAus (Migrated from github.com) approved these changes

2018-03-25 16:35:33 -05:00

Dylan-DPC-zz commented

2018-03-25 16:36:25 -05:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-03-25 16:42:31 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.300) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/358172990?utm_source=github_status&utm_medium=notification)

Sign in to join this conversation.

No reviewers

radix

Dylan-DPC-zz

KodrAus