support the winapi-rs crate by implementing `std::convert::From<GUID>`. #333

New issue

Closed

opened 2018-10-03 22:14:16 -05:00 by kinggoesgaming · 5 comments

kinggoesgaming commented

2018-10-03 22:14:16 -05:00

(Migrated from github.com)

Originally posted by @lzybkr in https://github.com/uuid-rs/uuid/issues/277#issuecomment-426824514

_Originally posted by @lzybkr in https://github.com/uuid-rs/uuid/issues/277#issuecomment-426824514_

KodrAus commented

2018-10-04 00:13:58 -05:00

(Migrated from github.com)

Adding from_guid and to_guid methods to Uuid behind a feature gate (could just use winapi as an optional dependency) could do this:

winapi = { version = "0.3", optional = true }

#[cfg(feature = "winapi")]
mod guid_support {
    use super::Uuid;
    use winapi::shared::guiddef::GUID;

    impl Uuid {
        pub fn from_guid(guid: GUID) -> Self;
        pub fn to_guid(&self) -> GUID;
    }
}

Adding `from_guid` and `to_guid` methods to `Uuid` behind a feature gate (could just use `winapi` as an optional dependency) could do this: ```toml winapi = { version = "0.3", optional = true } ``` ```rust #[cfg(feature = "winapi")] mod guid_support { use super::Uuid; use winapi::shared::guiddef::GUID; impl Uuid { pub fn from_guid(guid: GUID) -> Self; pub fn to_guid(&self) -> GUID; } } ```

KodrAus commented

2018-10-04 00:14:54 -05:00

(Migrated from github.com)