gh-uuid-rs/uuid
Watch
1
0
Fork
You've already forked uuid
 0
Code Issues 10 Pull requests 2 Releases Activity

try to get wasm builds running #358

Merged
kinggoesgaming merged 2 commits from cargo-web into master 2019-01-17 16:34:27 -06:00
Conversation 6 Commits 2 Files changed 1 +11 -11
kinggoesgaming commented 2019-01-17 14:36:19 -06:00 (Migrated from github.com)

I'm submitting a(n) other

Description

CI builds are failing because we are attempting to use cargo build for wasm builds. `cargo-web utility properly handles issues that are being caused

Motivation

Failures while trying to pass #355

Tests

Current builds build in CI

Related Issue(s)

N/A

**I'm submitting a(n)** other # Description CI builds are failing because we are attempting to use `cargo build` for wasm builds. `cargo-web utility properly handles issues that are being caused # Motivation Failures while trying to pass #355 # Tests Current builds build in CI # Related Issue(s) N/A
Dylan-DPC-zz (Migrated from github.com) reviewed 2019-01-17 14:36:19 -06:00
KodrAus (Migrated from github.com) reviewed 2019-01-17 15:49:49 -06:00
.travis.yml
@ -25,2 +23,4 @@
- cargo web build --features "v4 wasm-bindgen"
- cargo web build --features "v5 wasm-bindgen"
- os: linux
rust: nightly
KodrAus (Migrated from github.com) commented 2019-01-17 15:49:49 -06:00

Do you know what a simple cargo web build does differently than cargo build --target wasm32-unknown-unknown?

Do you know what a simple `cargo web build` does differently than `cargo build --target wasm32-unknown-unknown`?
KodrAus (Migrated from github.com) approved these changes 2019-01-17 15:49:57 -06:00
KodrAus (Migrated from github.com) left a comment

Looks good to me!

Looks good to me!
kinggoesgaming (Migrated from github.com) reviewed 2019-01-17 15:58:25 -06:00
.travis.yml
@ -25,2 +23,4 @@
- cargo web build --features "v4 wasm-bindgen"
- cargo web build --features "v5 wasm-bindgen"
- os: linux
rust: nightly
kinggoesgaming (Migrated from github.com) commented 2019-01-17 15:58:25 -06:00

Apparently there are hidden switches that are flipped around with cargo-web

The build failure particularly mentioned using it and it works

Apparently there are hidden switches that are flipped around with cargo-web The build failure particularly mentioned using it and it works
kinggoesgaming commented 2019-01-17 16:16:07 -06:00 (Migrated from github.com)

bors: r+

bors: r+
bors[bot] commented 2019-01-17 16:34:26 -06:00 (Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/builds/21704620) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/481100231?utm_source=github_status&utm_medium=notification)
Sign in to join this conversation.
Reviewers
No reviewers
Dylan-DPC-zz
KodrAus
Labels
Clear labels   
breaking
This causes a breaking change and will be merged to breaking branch.

  
bug

   
dependencies
Pull requests that update a dependency file

  
good first issue

   
help wanted

   
unstable
Tracking issue for an unstable optional dependency

No labels
breaking
bug
dependencies
good first issue
help wanted
unstable
Milestone
Clear milestone
No items
No milestone
0.7.2
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!358
No description provided.