Test MBEDTLS_CTR_DRBG_USE_128_BIT_KEY #291

Merged
gilles-peskine-arm merged 5 commits from ctr_drbg-test_aes_128 into development 2019-12-20 03:43:45 -06:00
gilles-peskine-arm commented 2019-10-07 12:09:57 -05:00 (Migrated from github.com)

Test MBEDTLS_CTR_DRBG_USE_128_BIT_KEY properly. Fix #289. Fix #290.

Follow-up of #287.

Needs backports: to 2.16 (almost identical); to 2.7 (only for the config.h and all.sh changes that are about MBEDTLS_ENTROPY_FORCE_SHA256).

Test `MBEDTLS_CTR_DRBG_USE_128_BIT_KEY` properly. Fix #289. Fix #290. Follow-up of #287. Needs backports: to 2.16 (almost identical); to 2.7 (only for the `config.h` and `all.sh` changes that are about `MBEDTLS_ENTROPY_FORCE_SHA256`).
gilles-peskine-arm commented 2019-11-12 10:05:47 -06:00 (Migrated from github.com)
New Jenkins run: https://jenkins-internal.mbed.com/job/mbed-crypto-pr/job/PR-291-merge/12/ → PASS
gilles-peskine-arm commented 2019-11-21 06:09:11 -06:00 (Migrated from github.com)

I'll rebase again :(

I'll rebase again :(
gilles-peskine-arm commented 2019-11-21 07:08:55 -06:00 (Migrated from github.com)
Rebased. Previous version in https://github.com/gilles-peskine-arm/mbed-crypto/tree/ctr_drbg-test_aes_128-2
AndrzejKurek (Migrated from github.com) approved these changes 2019-11-25 05:46:29 -06:00
piotr-now (Migrated from github.com) reviewed 2019-12-13 05:08:36 -06:00
@ -715,0 +720,4 @@
static const unsigned char result_nopr[16] =
{ 0x6c, 0x25, 0x27, 0x95, 0xa3, 0x62, 0xd6, 0xdb,
0x90, 0xfd, 0x69, 0xb5, 0x42, 0x9, 0x4b, 0x84 };
#else /* MBEDTLS_CTR_DRBG_USE_128_BIT_KEY */
piotr-now (Migrated from github.com) commented 2019-12-13 05:08:36 -06:00

Don't you think it would be more readable if there was added one extra line before and one after #else? Just as in the line 681?

Don't you think it would be more readable if there was added one extra line before and one after #else? Just as in the line 681?
piotr-now (Migrated from github.com) approved these changes 2019-12-13 06:32:27 -06:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!291
No description provided.