Test MBEDTLS_CTR_DRBG_USE_128_BIT_KEY #291
No reviewers
Labels
No labels
api-spec
bug
CLA requested
CLA valid
compliance
DO NOT MERGE
duplicate
enhancement
feature branch
good first issue
HEADER FORMATTING ISSUE
help wanted
Information
invalid
Jira status: AWAITING REVIEW
Jira status: CLOSED
Jira status: DONE
Jira status: IN PROGRESS
Jira status: IN REVIEW
Jira status: OPEN
Jira status: REOPENED
Jira status: RESOLVED
mirrored
mirror internally
needs: backports
needs: ci
needs: design review
needs: preceding PR
needs: review
needs: work
notabug
open for community contribution
Product Backlog
question
ready for merge
security
stale
type: bug
type: enhancement
type: question
web pages
wontfix
writing
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-ARMmbed/mbed-crypto!291
Loading…
Reference in a new issue
No description provided.
Delete branch "ctr_drbg-test_aes_128"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Test
MBEDTLS_CTR_DRBG_USE_128_BIT_KEYproperly. Fix #289. Fix #290.Follow-up of #287.
Needs backports: to 2.16 (almost identical); to 2.7 (only for the
config.handall.shchanges that are aboutMBEDTLS_ENTROPY_FORCE_SHA256).New Jenkins run: https://jenkins-internal.mbed.com/job/mbed-crypto-pr/job/PR-291-merge/12/ → PASS
I'll rebase again :(
Rebased. Previous version in https://github.com/gilles-peskine-arm/mbed-crypto/tree/ctr_drbg-test_aes_128-2
@ -715,0 +720,4 @@static const unsigned char result_nopr[16] ={ 0x6c, 0x25, 0x27, 0x95, 0xa3, 0x62, 0xd6, 0xdb,0x90, 0xfd, 0x69, 0xb5, 0x42, 0x9, 0x4b, 0x84 };#else /* MBEDTLS_CTR_DRBG_USE_128_BIT_KEY */Don't you think it would be more readable if there was added one extra line before and one after #else? Just as in the line 681?