Pass handle parameter last on key creation #111

Merged

gilles-peskine-arm merged 4 commits from psa-handle-param-order into psa-api-1.0-beta

2019-05-16 04:52:06 -05:00

gilles-peskine-arm commented

2019-05-15 13:25:02 -05:00

(Migrated from github.com)

Change the order of parameters for psa_import_key and psa_generate_derived_key to pass the handle output parameter last. This makes the order consistent with the general convention in the library to put inputs before outputs. Other key handle creation functions (psa_open_key, psa_generate_random_key, psa_copy_key) already had the handle output parameter last.

Change the order of parameters for `psa_import_key` and `psa_generate_derived_key` to pass the handle output parameter last. This makes the order consistent with the general convention in the library to put inputs before outputs. Other key handle creation functions (`psa_open_key`, `psa_generate_random_key`, `psa_copy_key`) already had the handle output parameter last.

yanesca (Migrated from github.com) approved these changes

2019-05-16 04:34:16 -05:00

yanesca (Migrated from github.com) left a comment

Minor: There is one more occurance of psa_generate_derived_key in
./docs/getting_started.md that needs updating.
Minor: There are more occurances of psa_imprt_key in
./docs/getting_started.md that needs updating.

- Minor: There is one more occurance of `psa_generate_derived_key` in `./docs/getting_started.md` that needs updating. - Minor: There are more occurances of `psa_imprt_key` in `./docs/getting_started.md` that needs updating.

gilles-peskine-arm commented

2019-05-16 04:46:12 -05:00

(Migrated from github.com)

getting_started.md is out of scope of the API document release. We'll update it in a batch later.

`getting_started.md` is out of scope of the API document release. We'll update it in a batch later.

Patater commented

2019-05-16 04:52:01 -05:00

(Migrated from github.com)

CI failures on API branch are to do with building with crypto as a submodule and also TLS using PSA, both of which we don't care about at this point in development.