Replace "generator" with "key derivation" #113

Merged

gilles-peskine-arm merged 9 commits from psa-generator_to_derivation into psa-api-1.0-beta

2019-05-16 12:20:30 -05:00

gilles-peskine-arm commented

2019-05-16 11:10:31 -05:00

(Migrated from github.com)

Generators are mostly about key derivation (currently: only about key derivation). "Generator" is not a commonly used term in cryptography. So favor "derivation" as terminology. Call a generator a key derivation operation structure, since it behaves like other multipart operation structures. Furthermore, the function names were not fully consistent; this PR makes them more consistent.

Generators are mostly about key derivation (currently: _only_ about key derivation). "Generator" is not a commonly used term in cryptography. So favor "derivation" as terminology. Call a generator a key derivation operation structure, since it behaves like other multipart operation structures. Furthermore, the function names were not fully consistent; this PR makes them more consistent.

yanesca (Migrated from github.com) approved these changes

2019-05-16 12:03:56 -05:00

yanesca (Migrated from github.com) left a comment

./programs/psa/key_ladder_demo.c still has a variable with name generator. Other than that it looks good to me.

`./programs/psa/key_ladder_demo.c` still has a variable with name `generator`. Other than that it looks good to me.

gilles-peskine-arm commented

2019-05-16 12:11:35 -05:00

(Migrated from github.com)

programs/psa/key_ladder_demo.c also uses an obsolete function, which is a bigger problem. It'll have to be reworked as part of https://github.com/ARMmbed/mbed-crypto/issues/37 .

`programs/psa/key_ladder_demo.c` also uses an obsolete function, which is a bigger problem. It'll have to be reworked as part of https://github.com/ARMmbed/mbed-crypto/issues/37 .

Patater commented

2019-05-16 12:20:21 -05:00

(Migrated from github.com)

CI failure is ABI job (known to fail until https://github.com/ARMmbed/mbedtls/pull/2636 lands in the development branch) and USE_PSA_CRYPTO, which doesn't work on the API branch.

CI failure is ABI job (known to fail until https://github.com/ARMmbed/mbedtls/pull/2636 lands in the development branch) and `USE_PSA_CRYPTO`, which doesn't work on the API branch.