Add docker-based test scripts #136

Closed
pkolbus wants to merge 1 commit from docker into development
pkolbus commented 2019-06-02 12:02:32 -05:00 (Migrated from github.com)

Enable running tests under Docker. This makes it easier to spin up an environment with all dependencies.

  • tests/docker/bionic/Dockerfile: Definition for the docker image.
  • tests/scripts/docker_env.sh: New helper script that creates the Docker image and has a function to run a command in the Docker container.
  • tests/docker/all-in-docker.sh: Wrapper for all.sh under Docker.
  • tests/docker/basic-in-docker.sh: Script that runs the same commands as .travis.yml, in Docker.
  • tests/make-in-docker.sh: Wrapper to run make in Docker.

Design and implementation are a port of ARMmbed/mbedtls#2314, but with the SSL-specific bits removed.

This resolves #135.

Enable running tests under Docker. This makes it easier to spin up an environment with all dependencies. * tests/docker/bionic/Dockerfile: Definition for the docker image. * tests/scripts/docker_env.sh: New helper script that creates the Docker image and has a function to run a command in the Docker container. * tests/docker/all-in-docker.sh: Wrapper for all.sh under Docker. * tests/docker/basic-in-docker.sh: Script that runs the same commands as .travis.yml, in Docker. * tests/make-in-docker.sh: Wrapper to run make in Docker. Design and implementation are a port of ARMmbed/mbedtls#2314, but with the SSL-specific bits removed. This resolves #135.
Patater (Migrated from github.com) reviewed 2019-06-02 12:02:32 -05:00
dgreen-arm (Migrated from github.com) reviewed 2019-06-02 12:02:32 -05:00
Patater commented 2019-09-04 03:06:37 -05:00 (Migrated from github.com)

@pkolbus Sorry to take so long to get to reviewing this. I see we now have conflicts in this PR. Could you please rebase on the latest development? We'll review from there. Thanks for your contribution and patience!

@pkolbus Sorry to take so long to get to reviewing this. I see we now have conflicts in this PR. Could you please rebase on the latest development? We'll review from there. Thanks for your contribution and patience!
pkolbus commented 2019-10-08 06:55:03 -05:00 (Migrated from github.com)

Hmm, it looks like some form of these were already merged in as a straight port of mbed TLS (see commit b348a3b258). So no need for this PR anymore.

Hmm, it looks like some form of these were already merged in as a straight port of mbed TLS (see commit b348a3b2580da4e5cb3f73fb0c57753a2e6150c5). So no need for this PR anymore.

Pull request closed

Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!136
No description provided.