Documented some algorithms #161

Closed

adrianlshaw wants to merge 2 commits from document_algorithms into development

adrianlshaw commented

2019-07-04 10:13:36 -05:00

(Migrated from github.com)

This small PR introduces some small, consistent descriptions to the various cipher modes.

GMAC is removed because it can't be implemented with the current version of the API.

This small PR introduces some small, consistent descriptions to the various cipher modes. GMAC is removed because it can't be implemented with the current version of the API.

gilles-peskine-arm (Migrated from github.com) requested changes

2019-07-04 10:43:21 -05:00

gilles-peskine-arm (Migrated from github.com) left a comment

Thanks for the new text. But please don't remove GMAC in the same commit where you add text. Furthermore, if you remove GMAC, you also need to remove the places where it's used.

adrianlshaw commented

2019-07-05 08:14:26 -05:00

(Migrated from github.com)

Thanks for the review. I've taken your advice. Hope I've been less sloppy this time round.

gilles-peskine-arm commented

2019-07-05 08:56:13 -05:00

(Migrated from github.com)

The build is still failing. You should have permission to view Jenkins results now, by the way.

👍 1

adrianlshaw commented

2019-07-08 10:42:14 -05:00

(Migrated from github.com)

The CI errors don't look related to any code I've touched. Am I wrong? The tips of my fork are up to date and no merge issues detected locally. Any advice?

gilles-peskine-arm (Migrated from github.com) reviewed

2019-07-08 12:26:28 -05:00

gilles-peskine-arm commented

2019-07-08 12:29:31 -05:00

(Migrated from github.com)

The diff is fine, but please rebase on top of the branch psa-api-1.0-beta, which is the branch that the specification is typeset from. The development branch has the latest version of Mbed Crypto, but complies with an older version of the PSA API.

The "Pre Test Checks", "Travis CI" and "Crypto Testing" jobs are expected to pass. "TLS Testing", "pr-head" and "pr-merge" are expected to fail on the API branch.

The diff is fine, but please rebase on top of the branch `psa-api-1.0-beta`, which is the branch that the specification is typeset from. The `development` branch has the latest version of Mbed Crypto, but complies with an older version of the PSA API. The "Pre Test Checks", "Travis CI" and "Crypto Testing" jobs are expected to pass. "TLS Testing", "pr-head" and "pr-merge" are expected to fail on the API branch.

adrianlshaw commented

2019-07-11 10:02:49 -05:00

(Migrated from github.com)