gh-ARMmbed/mbed-crypto
Watch
1
0
Fork
You've already forked mbed-crypto
 0
Code Issues 36 Pull requests 1 Releases 7 Activity

Add CMake option for explicitly link library to trusted_storage #186

Merged
moshe-shahar merged 2 commits from psa-storage-and-cmake-fix into development 2019-07-24 09:52:21 -05:00
Conversation 6 Commits 2 Files changed 1 +5
moshe-shahar commented 2019-07-21 02:04:31 -05:00 (Migrated from github.com)

CMake option name: LINK_WITH_TRUSTED_STORAGE
Default value is ON since the default of mbedtls for MBEDTLS_PSA_ITS_FILE_C is using ITS.

This PR is based on https://github.com/ARMmbed/mbed-crypto/pull/180 with the addition of one commit. Please merge after it.

The new option assumes trusted_storage library exist and force mbedcrypto library to link with it. Any application/test uses emulated ITS (by defining MBEDTLS_PSA_ITS_FILE_C) should set this option to OFF.

CMake option name: LINK_WITH_TRUSTED_STORAGE Default value is `ON` since the default of mbedtls for `MBEDTLS_PSA_ITS_FILE_C` [is using ITS](https://github.com/ARMmbed/mbedtls/blob/ff645d9838f4797c726562d90c0a9ae5207ea86f/include/mbedtls/config.h#L2872). This PR is based on https://github.com/ARMmbed/mbed-crypto/pull/180 with the addition of one commit. Please merge after it. The new option assumes `trusted_storage` library exist and force `mbedcrypto` library to link with it. Any application/test uses emulated ITS (by defining `MBEDTLS_PSA_ITS_FILE_C`) should set this option to `OFF`.
moshe-shahar commented 2019-07-21 02:08:30 -05:00 (Migrated from github.com)

@Patater, please review.

@simonqhughes, FYI.

@Patater, please review. @simonqhughes, FYI.
Patater (Migrated from github.com) requested changes 2019-07-24 05:37:26 -05:00
library/CMakeLists.txt
@ -1,6 +1,7 @@
option(USE_STATIC_MBEDTLS_LIBRARY "Build mbed TLS static library." ON)
Patater (Migrated from github.com) commented 2019-07-24 05:36:43 -05:00

This should default to OFF, as most of our Linux systems don't have a trusted_storage library available. On Mbed Linux, this can be changed to ON.

This should default to OFF, as most of our Linux systems don't have a trusted_storage library available. On Mbed Linux, this can be changed to ON.
library/CMakeLists.txt
Patater (Migrated from github.com) commented 2019-07-24 05:37:21 -05:00

Do we need to link with trusted_storage in Makefile builds as well? Seems odd to only add the possibility to link with trusted_stored for CMake.

Do we need to link with trusted_storage in Makefile builds as well? Seems odd to only add the possibility to link with trusted_stored for CMake.
Patater (Migrated from github.com) reviewed 2019-07-24 05:45:35 -05:00
library/CMakeLists.txt
Patater (Migrated from github.com) commented 2019-07-24 05:45:35 -05:00

I've filed https://github.com/ARMmbed/mbed-crypto/issues/188 for this

I've filed https://github.com/ARMmbed/mbed-crypto/issues/188 for this
moshe-shahar (Migrated from github.com) reviewed 2019-07-24 06:23:08 -05:00
library/CMakeLists.txt
@ -1,6 +1,7 @@
option(USE_STATIC_MBEDTLS_LIBRARY "Build mbed TLS static library." ON)
moshe-shahar (Migrated from github.com) commented 2019-07-24 06:23:07 -05:00

done

done
Patater (Migrated from github.com) approved these changes 2019-07-24 07:08:49 -05:00
Patater (Migrated from github.com) left a comment

LGTM

LGTM
simonqhughes (Migrated from github.com) approved these changes 2019-07-24 09:51:03 -05:00
simonqhughes (Migrated from github.com) left a comment

lgtm

lgtm
Sign in to join this conversation.
Reviewers
No reviewers
Patater
simonqhughes
Labels
Clear labels   
api-spec
Issue or PR about the PSA specifications

  
bug
Something isn't working

  
CLA requested

   
CLA valid

   
compliance
Discrepancy between the library and the PSA Crypto API specification

  
DO NOT MERGE
The PR is not intended to be merged (yet). Usually used for a review of worked in progress.

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature branch
This issue or PR is for a short-term feature branch which doesn't have its own label.

  
good first issue
Good for newcomers

  
HEADER FORMATTING ISSUE

   
help wanted
Extra attention is needed

  
Information

   
invalid
This doesn't seem right

  
Jira status: AWAITING REVIEW

   
Jira status: CLOSED

   
Jira status: DONE

   
Jira status: IN PROGRESS

   
Jira status: IN REVIEW

   
Jira status: OPEN

   
Jira status: REOPENED

   
Jira status: RESOLVED

   
mirrored

   
mirror internally

   
needs: backports
Needs backports to Mbed TLS branches

  
needs: ci
Needs a passing full CI run

  
needs: design review

   
needs: preceding PR
Requires another PR to be merged first

  
needs: review
The pull request is ready for review. This generally means that it has no known issues.

  
needs: work
The pull request needs rework before it can be merged.

  
notabug
The bug is not considered to be a defect, but by design.

  
open for community contribution

   
Product Backlog

   
question
Further information is requested

  
ready for merge
Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only.

  
security
Security expertise requested in review

  
stale
This PR is not being actively worked on. It can be considered abandoned work.

  
type: bug

   
type: enhancement

   
type: question

   
web pages
The /docs directory in the master branch is shown on https://armmbed.github.io/mbed-crypto

  
wontfix
The cost of fixing the bug or managing it in the bug list is not justified.

  
writing
Documentation wording and formatting

No labels
api-spec
bug
CLA requested
CLA valid
compliance
DO NOT MERGE
duplicate
enhancement
feature branch
good first issue
HEADER FORMATTING ISSUE
help wanted
Information
invalid
Jira status: AWAITING REVIEW
Jira status: CLOSED
Jira status: DONE
Jira status: IN PROGRESS
Jira status: IN REVIEW
Jira status: OPEN
Jira status: REOPENED
Jira status: RESOLVED
mirrored
mirror internally
needs: backports
needs: ci
needs: design review
needs: preceding PR
needs: review
needs: work
notabug
open for community contribution
Product Backlog
question
ready for merge
security
stale
type: bug
type: enhancement
type: question
web pages
wontfix
writing
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!186
No description provided.