Update Windows Crypto APIs #341

Closed

simonbutcher wants to merge 1 commit from win32-crypto-api-fix into development

simonbutcher commented

2020-01-06 12:47:12 -06:00

(Migrated from github.com)

Description

This is an update on Mbed TLS PR #1453 to address issues building with mingw and Visual Studio when using cmake generated files.

To quote the original PR.

CryptGenRandom and lstrlenW are not permitted in Windows Store apps, meaning apps that use mbedTLS can't ship in the Windows Store. Instead, use BCryptGenRandom and wcslen, respectively, which are permitted.

Also make sure conversions between size_t, ULONG, and int are always done safely; on a 64-bit platform, these types are differnt sizes.

Also, removed the obsolete Visual Studio 6 data files which are no longer used.

Status

WORK IN PROGRESS

Requires Backporting

Migrations

Todos

Tests
[] Documentation
[] Changelog updated
[] Backported

## Description This is an update on [Mbed TLS PR #1453](https://github.com/ARMmbed/mbedtls/pull/1453) to address issues building with mingw and Visual Studio when using `cmake` generated files. To quote the original PR. > CryptGenRandom and lstrlenW are not permitted in Windows Store apps, meaning apps that use mbedTLS can't ship in the Windows Store. Instead, use BCryptGenRandom and wcslen, respectively, which are permitted. > > Also make sure conversions between size_t, ULONG, and int are always done safely; on a 64-bit platform, these types are differnt sizes. > Also, removed the obsolete Visual Studio 6 data files which are no longer used. ## Status **WORK IN PROGRESS** ## Requires Backporting NO ## Migrations NO ## Todos - [X] Tests - [] Documentation - [] Changelog updated - [] Backported

mpg commented

2020-03-26 05:42:37 -05:00

(Migrated from github.com)

This was a complement to a PR on the TLS side, and it's currently labeled "do not merge", so following the merge back from the mbed-crypo repo to the mbedtls repo, I'm closing it with the reasoning that the PR on the mbedtls repo can be used to complete the work.

This was a complement to a PR on the TLS side, and it's currently labeled "do not merge", so following the merge back from the mbed-crypo repo to the mbedtls repo, I'm closing it with the reasoning that [the PR on the mbedtls repo](https://github.com/ARMmbed/mbedtls/pull/1453) can be used to complete the work.