Fix minor defects found by Coverity #349

Merged

gilles-peskine-arm merged 5 commits from coverity-20200115-crypto into development

2020-01-29 09:05:12 -06:00

gilles-peskine-arm commented

2020-01-21 14:19:03 -06:00

(Migrated from github.com)

One instance of dead code in the product. IOTCRYPT-475
Some missing return value checks in test code.
Several cases where test code could cause a resource leak or crash if the test fails in certain ways.
(Found while I was looking at the code) Make ASSERT_ALLOC_WEAK skip the test rather than pass it if it fails, as was intended all along.

The missing return value checks should be backported where applicable. The other bugs are so minor that they don't need backporting (but can be). ASSERT_ALLOC_WEAK is not in the LTS branches.

Backports

* One instance of dead code in the product. IOTCRYPT-475 * Some missing return value checks in test code. * Several cases where test code could cause a resource leak or crash if the test fails in certain ways. * (Found while I was looking at the code) Make `ASSERT_ALLOC_WEAK` skip the test rather than pass it if it fails, as was intended all along. The missing return value checks should be backported where applicable. The other bugs are so minor that they don't need backporting (but can be). `ASSERT_ALLOC_WEAK` is not in the LTS branches. ### Backports - 2.16 https://github.com/ARMmbed/mbedtls/pull/3001 - 2.7 https://github.com/ARMmbed/mbedtls/pull/3002

mpg (Migrated from github.com) approved these changes

2020-01-22 03:43:04 -06:00

mpg (Migrated from github.com) left a comment