gh-ARMmbed/mbed-crypto
Watch
1
0
Fork
You've already forked mbed-crypto
 0
Code Issues 36 Pull requests 1 Releases 7 Activity

Bump version to Mbed TLS 2.21.0 #370

Merged
yanesca merged 1 commit from update-version-2.21.0 into development 2020-02-19 08:21:12 -06:00
Conversation 6 Commits 1 Files changed 4 +8 -8
yanesca commented 2020-02-19 05:55:16 -06:00 (Migrated from github.com)

Not bumping the SO version:

The API/ABI breaking changes only affect internal APIs (changes related to mbedtls_asn1_traverse_sequence_of()) and to PSA, which is from the point of view of Mbed TLS is an unstable API.

Not bumping the SO version: The API/ABI breaking changes only affect internal APIs (changes related to `mbedtls_asn1_traverse_sequence_of()`) and to PSA, which is from the point of view of Mbed TLS is an unstable API.
mpg (Migrated from github.com) reviewed 2020-02-19 05:55:16 -06:00
danh-arm (Migrated from github.com) approved these changes 2020-02-19 06:59:33 -06:00
gilles-peskine-arm commented 2020-02-19 07:01:19 -06:00 (Migrated from github.com)

Don't we need to update the crypto submodule and the changelog first?

Don't we need to update the crypto submodule and the changelog first?
yanesca commented 2020-02-19 07:02:59 -06:00 (Migrated from github.com)

This is mbed-crypto, it does not have it's own version reporting, it reports the Mbed TLS version it is included in. I wanted to update the version here first so that we can do a single submodule update on Mbed TLS instead of two.

This is mbed-crypto, it does not have it's own version reporting, it reports the Mbed TLS version it is included in. I wanted to update the version here first so that we can do a single submodule update on Mbed TLS instead of two.
gilles-peskine-arm (Migrated from github.com) approved these changes 2020-02-19 07:22:36 -06:00
gilles-peskine-arm (Migrated from github.com) left a comment

LGTM. To be immediately followed by updating the submodule and updating the library version in mbedtls.

LGTM. To be immediately followed by updating the submodule and updating the library version in mbedtls.
yanesca commented 2020-02-19 08:20:26 -06:00 (Migrated from github.com)

The CI failures are mostly an issue in Mbed OS, with one exception, which is an ssl-opt.sh DTLS spurious resend. All of these are known issues unrelated to this PR.

The CI failures are mostly an issue in Mbed OS, with one exception, which is an ssl-opt.sh DTLS spurious resend. All of these are known issues unrelated to this PR.
Sign in to join this conversation.
Reviewers
No reviewers
mpg
danh-arm
gilles-peskine-arm
Labels
Clear labels   
api-spec
Issue or PR about the PSA specifications

  
bug
Something isn't working

  
CLA requested

   
CLA valid

   
compliance
Discrepancy between the library and the PSA Crypto API specification

  
DO NOT MERGE
The PR is not intended to be merged (yet). Usually used for a review of worked in progress.

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature branch
This issue or PR is for a short-term feature branch which doesn't have its own label.

  
good first issue
Good for newcomers

  
HEADER FORMATTING ISSUE

   
help wanted
Extra attention is needed

  
Information

   
invalid
This doesn't seem right

  
Jira status: AWAITING REVIEW

   
Jira status: CLOSED

   
Jira status: DONE

   
Jira status: IN PROGRESS

   
Jira status: IN REVIEW

   
Jira status: OPEN

   
Jira status: REOPENED

   
Jira status: RESOLVED

   
mirrored

   
mirror internally

   
needs: backports
Needs backports to Mbed TLS branches

  
needs: ci
Needs a passing full CI run

  
needs: design review

   
needs: preceding PR
Requires another PR to be merged first

  
needs: review
The pull request is ready for review. This generally means that it has no known issues.

  
needs: work
The pull request needs rework before it can be merged.

  
notabug
The bug is not considered to be a defect, but by design.

  
open for community contribution

   
Product Backlog

   
question
Further information is requested

  
ready for merge
Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only.

  
security
Security expertise requested in review

  
stale
This PR is not being actively worked on. It can be considered abandoned work.

  
type: bug

   
type: enhancement

   
type: question

   
web pages
The /docs directory in the master branch is shown on https://armmbed.github.io/mbed-crypto

  
wontfix
The cost of fixing the bug or managing it in the bug list is not justified.

  
writing
Documentation wording and formatting

No labels
api-spec
bug
CLA requested
CLA valid
compliance
DO NOT MERGE
duplicate
enhancement
feature branch
good first issue
HEADER FORMATTING ISSUE
help wanted
Information
invalid
Jira status: AWAITING REVIEW
Jira status: CLOSED
Jira status: DONE
Jira status: IN PROGRESS
Jira status: IN REVIEW
Jira status: OPEN
Jira status: REOPENED
Jira status: RESOLVED
mirrored
mirror internally
needs: backports
needs: ci
needs: design review
needs: preceding PR
needs: review
needs: work
notabug
open for community contribution
Product Backlog
question
ready for merge
security
stale
type: bug
type: enhancement
type: question
web pages
wontfix
writing
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!370
No description provided.