Build: Updated CMAKE_C_FLAGS for IAR #375

Merged
TTornblom merged 1 commit from development into development 2020-03-26 06:42:13 -05:00
TTornblom commented 2020-02-25 03:45:16 -06:00 (Migrated from github.com)

Updated the IAR specific CMAKE_C_FLAGS settings in CMakeLists.txt to
allow building TF-M (Trusted Firmware) with mbed-crypto as a subproject.

Signed-off-by: TTornblom thomas.tornblom@iar.com

Updated the IAR specific CMAKE_C_FLAGS settings in CMakeLists.txt to allow building TF-M (Trusted Firmware) with mbed-crypto as a subproject. Signed-off-by: TTornblom <thomas.tornblom@iar.com>
TTornblom commented 2020-02-28 08:54:10 -06:00 (Migrated from github.com)

What are the failing CI tests? I have no access to the details of the failed tests.

What are the failing CI tests? I have no access to the details of the failed tests.
AndrzejKurek commented 2020-03-02 08:04:00 -06:00 (Migrated from github.com)

All of the mbed-os tests using K64F with GCC_ARM and IAR are failing. The build is stopped pretty soon, so this is probably not the only error that will be encountered:

Compile [ 7.4%]: attest_crypto_keys.c
[Error] attest_crypto_keys.c@54,9: duplicate case value
[Error] attest_crypto_keys.c@57,9: duplicate case value
[Error] attest_crypto_keys.c@63,9: duplicate case value
[ERROR] ./mbed-os/components/TARGET_PSA/services/attestation/COMPONENT_PSA_SRV_IMPL/attest_crypto_keys.c: In function 'get_curve':
./mbed-os/components/TARGET_PSA/services/attestation/COMPONENT_PSA_SRV_IMPL/attest_crypto_keys.c:54:9: error: duplicate case value
54 | case PSA_ECC_CURVE_SECP384R1:

Please build one of the mbedtls mbed-os examples (like hashing, or benchmark), by running:
mbed compile -m K64F -t GCC_ARM or mbed compile -m K64F -t IAR in the respective directory to get full results.

All of the mbed-os tests using K64F with GCC_ARM and IAR are failing. The build is stopped pretty soon, so this is probably not the only error that will be encountered: > Compile [ 7.4%]: attest_crypto_keys.c > [Error] attest_crypto_keys.c@54,9: duplicate case value > [Error] attest_crypto_keys.c@57,9: duplicate case value > [Error] attest_crypto_keys.c@63,9: duplicate case value > [ERROR] ./mbed-os/components/TARGET_PSA/services/attestation/COMPONENT_PSA_SRV_IMPL/attest_crypto_keys.c: In function 'get_curve': > ./mbed-os/components/TARGET_PSA/services/attestation/COMPONENT_PSA_SRV_IMPL/attest_crypto_keys.c:54:9: error: duplicate case value > 54 | case PSA_ECC_CURVE_SECP384R1: Please build one of the mbedtls mbed-os examples (like hashing, or benchmark), by running: `mbed compile -m K64F -t GCC_ARM` or `mbed compile -m K64F -t IAR` in the respective directory to get full results.
TTornblom commented 2020-03-03 02:47:07 -06:00 (Migrated from github.com)

I don't see that this is connected to my update in any way.

This appears to have broken with the update to the latest mbed-crypto in mbed-os and should be addressed there, not with my fix.

Appears that attest_crypto_keys.c, which is part of mbed-os, is using deprecated constants, which is why compilation fails. I would be highly surprised if this compiles with any toolchain.

I don't see that this is connected to my update in any way. This appears to have broken with the update to the latest mbed-crypto in mbed-os and should be addressed there, not with my fix. Appears that attest_crypto_keys.c, which is part of mbed-os, is using deprecated constants, which is why compilation fails. I would be highly surprised if this compiles with any toolchain.
TTornblom commented 2020-03-11 08:39:59 -05:00 (Migrated from github.com)

@gilles-peskine-arm Please review

@gilles-peskine-arm Please review
gilles-peskine-arm (Migrated from github.com) approved these changes 2020-03-11 09:15:18 -05:00
AndrzejKurek (Migrated from github.com) approved these changes 2020-03-18 10:10:56 -05:00
mpg commented 2020-03-26 06:41:26 -05:00 (Migrated from github.com)

Everything passed in the CI except some known issues independent from this PR.

Everything passed in the CI except some known issues independent from this PR.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!375
No description provided.