gh-ARMmbed/mbed-crypto
Watch
1
0
Fork
You've already forked mbed-crypto
 0
Code Issues 36 Pull requests 1 Releases 7 Activity

Have issue and PR templates redirect to Mbed TLS #392

Merged
mpg merged 1 commit from no-new-issue-or-pr into development 2020-03-25 03:55:34 -05:00
Conversation 12 Commits 1 Files changed 2 +17 -41
mpg commented 2020-03-24 05:56:53 -05:00 (Migrated from github.com)

This is a follow-up to https://github.com/ARMmbed/mbedtls/pull/3085

We don't really want to disable issues and PR completely for this repo (for now), as this would make the existing ones invisible, and there are issues we want to track and PRs that are on their way to getting merged, and I don't think github offers and middle ground of keeping the existing ones but forbidding new ones.

So the second best thing is what this PR does: discourage people to create new issues and PRs here, and encourage them to open them in the mbedtls repo instead.

This is a follow-up to https://github.com/ARMmbed/mbedtls/pull/3085 We don't really want to disable issues and PR completely for this repo (for now), as this would make the existing ones invisible, and there are issues we want to track and PRs that are on their way to getting merged, and I don't think github offers and middle ground of keeping the existing ones but forbidding new ones. So the second best thing is what this PR does: discourage people to create new issues and PRs here, and encourage them to open them in the mbedtls repo instead.
gilles-peskine-arm (Migrated from github.com) reviewed 2020-03-24 06:26:48 -05:00
ronald-cron-arm (Migrated from github.com) reviewed 2020-03-24 08:31:27 -05:00
.github/issue_template.md
ronald-cron-arm (Migrated from github.com) commented 2020-03-24 08:29:45 -05:00

"Arm Mbed / mbedtls" instead of just "mbedtls" ?

"Arm Mbed / mbedtls" instead of just "mbedtls" ?
.github/pull_request_template.md
@ -0,0 +1,10 @@
We are no longer accepting new pull requests in this repository
ronald-cron-arm (Migrated from github.com) commented 2020-03-24 08:25:33 -05:00

typo, "requrests" instead of requests

typo, "requrests" instead of requests
.github/pull_request_template.md
@ -0,0 +4,4 @@
Mbed Crypto is now maintained as part of Mbed TLS, see
https://github.com/ARMmbed/mbedtls/issues/3064
Please open your pull request in the mbedtls repository:
ronald-cron-arm (Migrated from github.com) commented 2020-03-24 08:30:11 -05:00

ditto for "mbedtls"

ditto for "mbedtls"
.github/pull_request_template.md
@ -0,0 +7,4 @@
Please open your pull request in the mbedtls repository:
https://github.com/ARMmbed/mbedtls/pulls
Thanks for your interest in Mbed Crypto!
ronald-cron-arm (Migrated from github.com) commented 2020-03-24 08:30:37 -05:00

What about to add that in issue_template.md" as well?

What about to add that in issue_template.md" as well?
danh-arm (Migrated from github.com) reviewed 2020-03-24 11:21:16 -05:00
.github/issue_template.md
danh-arm (Migrated from github.com) commented 2020-03-24 11:21:16 -05:00

We don't need to worry about trademark compliance in technical docs. Also, we don't want to mention Arm seeing as we want this to be open governance now. So either "mbedtls" or "Mbed TLS" is fine I think.

We don't need to worry about trademark compliance in technical docs. Also, we don't want to mention Arm seeing as we want this to be open governance now. So either "mbedtls" or "Mbed TLS" is fine I think.
danh-arm (Migrated from github.com) reviewed 2020-03-24 13:01:08 -05:00
danh-arm (Migrated from github.com) left a comment
No description provided.
OK by me, apart from Ronald's minor comments. I guess at least the typo should be fixed but no need for re-review.
mpg (Migrated from github.com) reviewed 2020-03-25 03:28:54 -05:00
.github/pull_request_template.md
@ -0,0 +1,10 @@
We are no longer accepting new pull requests in this repository
mpg (Migrated from github.com) commented 2020-03-25 03:28:54 -05:00

Aw. Thanks for catching.

Aw. Thanks for catching.
mpg (Migrated from github.com) reviewed 2020-03-25 03:29:48 -05:00
.github/issue_template.md
mpg (Migrated from github.com) commented 2020-03-25 03:29:48 -05:00

I think since there is a link below it's OK to use the short name of the repo (without the organisation prefix) in the sentence.

I think since there is a link below it's OK to use the short name of the repo (without the organisation prefix) in the sentence.
mpg (Migrated from github.com) reviewed 2020-03-25 03:30:47 -05:00
.github/pull_request_template.md
@ -0,0 +7,4 @@
Please open your pull request in the mbedtls repository:
https://github.com/ARMmbed/mbedtls/pulls
Thanks for your interest in Mbed Crypto!
mpg (Migrated from github.com) commented 2020-03-25 03:30:47 -05:00

I think it's there too, but for some reason the diff hides it at the end. (I'll never understand why we can't seem to come up with diff tools that generate more sensible diffs.)

I think it's there too, but for some reason the diff hides it at the end. (I'll never understand why we can't seem to come up with diff tools that generate more sensible diffs.)
gilles-peskine-arm (Migrated from github.com) approved these changes 2020-03-25 03:39:59 -05:00
ronald-cron-arm (Migrated from github.com) reviewed 2020-03-25 03:40:06 -05:00
.github/issue_template.md
ronald-cron-arm (Migrated from github.com) commented 2020-03-25 03:40:06 -05:00

ok fine by me

ok fine by me
ronald-cron-arm (Migrated from github.com) reviewed 2020-03-25 03:40:52 -05:00
.github/pull_request_template.md
@ -0,0 +7,4 @@
Please open your pull request in the mbedtls repository:
https://github.com/ARMmbed/mbedtls/pulls
Thanks for your interest in Mbed Crypto!
ronald-cron-arm (Migrated from github.com) commented 2020-03-25 03:40:52 -05:00

Yes I missed it, I can see it now. Sorry for the noise.

Yes I missed it, I can see it now. Sorry for the noise.
ronald-cron-arm (Migrated from github.com) approved these changes 2020-03-25 03:51:48 -05:00
mpg commented 2020-03-25 03:54:41 -05:00 (Migrated from github.com)

This has two approvals and we don't need to wait for the CI to complete as it's only touching files in the .github directory.

This has two approvals and we don't need to wait for the CI to complete as it's only touching files in the `.github` directory.
Sign in to join this conversation.
Reviewers
No reviewers
gilles-peskine-arm
ronald-cron-arm
Labels
Clear labels   
api-spec
Issue or PR about the PSA specifications

  
bug
Something isn't working

  
CLA requested

   
CLA valid

   
compliance
Discrepancy between the library and the PSA Crypto API specification

  
DO NOT MERGE
The PR is not intended to be merged (yet). Usually used for a review of worked in progress.

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature branch
This issue or PR is for a short-term feature branch which doesn't have its own label.

  
good first issue
Good for newcomers

  
HEADER FORMATTING ISSUE

   
help wanted
Extra attention is needed

  
Information

   
invalid
This doesn't seem right

  
Jira status: AWAITING REVIEW

   
Jira status: CLOSED

   
Jira status: DONE

   
Jira status: IN PROGRESS

   
Jira status: IN REVIEW

   
Jira status: OPEN

   
Jira status: REOPENED

   
Jira status: RESOLVED

   
mirrored

   
mirror internally

   
needs: backports
Needs backports to Mbed TLS branches

  
needs: ci
Needs a passing full CI run

  
needs: design review

   
needs: preceding PR
Requires another PR to be merged first

  
needs: review
The pull request is ready for review. This generally means that it has no known issues.

  
needs: work
The pull request needs rework before it can be merged.

  
notabug
The bug is not considered to be a defect, but by design.

  
open for community contribution

   
Product Backlog

   
question
Further information is requested

  
ready for merge
Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only.

  
security
Security expertise requested in review

  
stale
This PR is not being actively worked on. It can be considered abandoned work.

  
type: bug

   
type: enhancement

   
type: question

   
web pages
The /docs directory in the master branch is shown on https://armmbed.github.io/mbed-crypto

  
wontfix
The cost of fixing the bug or managing it in the bug list is not justified.

  
writing
Documentation wording and formatting

No labels
api-spec
bug
CLA requested
CLA valid
compliance
DO NOT MERGE
duplicate
enhancement
feature branch
good first issue
HEADER FORMATTING ISSUE
help wanted
Information
invalid
Jira status: AWAITING REVIEW
Jira status: CLOSED
Jira status: DONE
Jira status: IN PROGRESS
Jira status: IN REVIEW
Jira status: OPEN
Jira status: REOPENED
Jira status: RESOLVED
mirrored
mirror internally
needs: backports
needs: ci
needs: design review
needs: preceding PR
needs: review
needs: work
notabug
open for community contribution
Product Backlog
question
ready for merge
security
stale
type: bug
type: enhancement
type: question
web pages
wontfix
writing
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto!392
No description provided.