Feature/cheat manager shortcut #5

Closed

thatboialex wants to merge 14 commits from feature/cheat-manager-shortcut into active

thatboialex commented

2026-05-04 18:18:12 -05:00

(Migrated from github.com)

No description provided.

chatgpt-codex-connector[bot] commented

2026-05-04 18:21:07 -05:00

(Migrated from github.com)

💡 Codex Review

github.com/ItsJokerZz/NexusFramework@6fa8dd0986/src/NexusCheatFramework.Core/Services/CheatManagerSession.cs (L219)
Trigger custom combos directly instead of updating an Off detector

For HoldL1R1Square, HoldL1R1Triangle, and Custom, BuildDetector maps the detector mode to Off, then HandleCustomCombo tries to fire by calling detector.Update(...). Because ShortcutDetector.Update exits immediately when mode is Off, these controller shortcuts never emit OnTrigger (including the default open/close trigger), so the cheat manager cannot be opened/closed from those combos even when /pad_state works.

github.com/ItsJokerZz/NexusFramework@6fa8dd0986/src/NexusCheatFramework.Web/Program.cs (L446)
Apply shortcut-config updates to the live session

This endpoint persists new shortcut settings but does not update the already-running CheatManagerSession (which is created once at startup from the initial config), so changing cheatManagerTrigger, closeTrigger, or custom chord via API/CLI has no runtime effect until the WebUI process is restarted. That makes shortcut set appear successful while controller behavior stays unchanged.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review https://github.com/ItsJokerZz/NexusFramework/blob/6fa8dd0986f4f2a0f4d13bd08d5f898af21fb1dd/src/NexusCheatFramework.Core/Services/CheatManagerSession.cs#L219 **![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat) Trigger custom combos directly instead of updating an Off detector** For `HoldL1R1Square`, `HoldL1R1Triangle`, and `Custom`, `BuildDetector` maps the detector mode to `Off`, then `HandleCustomCombo` tries to fire by calling `detector.Update(...)`. Because `ShortcutDetector.Update` exits immediately when mode is `Off`, these controller shortcuts never emit `OnTrigger` (including the default open/close trigger), so the cheat manager cannot be opened/closed from those combos even when `/pad_state` works. --- https://github.com/ItsJokerZz/NexusFramework/blob/6fa8dd0986f4f2a0f4d13bd08d5f898af21fb1dd/src/NexusCheatFramework.Web/Program.cs#L446 **![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Apply shortcut-config updates to the live session** This endpoint persists new shortcut settings but does not update the already-running `CheatManagerSession` (which is created once at startup from the initial config), so changing `cheatManagerTrigger`, `closeTrigger`, or custom chord via API/CLI has no runtime effect until the WebUI process is restarted. That makes `shortcut set` appear successful while controller behavior stays unchanged. <details> <summary>ℹ️ About Codex in GitHub</summary> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>